If a block menu is used in the navigation bar, bullets have been removed and links are inline, but the block titles and margin still exists. It would be useful if these were removed.

CommentFileSizeAuthor
#1 1144240-remove_block_title_adjust_menu_block_margin_in_navbar.patch469 bytesKrisBulman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented
Status: Active » Needs review
FileSize
1144240-remove_block_title_adjust_menu_block_margin_in_navbar.patch469 bytes

this patch applies the above changes in STARTERKIT only

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented
Assigned: KrisBulman » Unassigned
KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented

Just noticed I should have done this in the sass navigation file.. When attempting to approach it, I sadly failed on getting the ruby gem sass installed on my Debian vm. :(

barraponto’s picture

barraponto CreditAttribution: barraponto commented

Kris, you should try using rvm https://rvm.beginrescueend.com/ it helps a lot. Takes some effort to get used, but you can try all gem combinations you can think of (I use it to move from sass/compass betas and stables, and testing out my drupal compass plugin).

barraponto’s picture

barraponto CreditAttribution: barraponto commented
Issue tags: +Accessibility, +DAX

btw, shouldn't we look for a proper accessibility solution for this? display: none hides things from screen readers as well.

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented

If the idea is to give the title access to screen readers, then it would work to replace display:none with this

    clip: rect(1px 1px 1px 1px); /* IE6 & 7 */
    clip: rect(1px, 1px, 1px, 1px);
    position: absolute !important;

unless there is a better way by adding an element-hidden class to menus that appear in the navigation region.. might be overkill though.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Actually, better to just use the pre-defined class element-invisible on any item you don't want to appear on the browser, but do want to be visible to assistive technology. See:

http://drupal.org/update/themes/6/7#element-hidden

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Component: CSS/HTML markup » layout.css

Zen now has a element-invisible() mixin in the _custom.scss partial.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Needs work
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Component: layout.css » CSS/SASS/HTML markup

This makes sense.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: remove block-title in navigation & adjust margins to same as main-menu » In navigation region, make menu block styling the same as theme's menu links

Looks like stripping the .content div from the block.tpl broke this functionality in the interim.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: In navigation region, make menu block styling the same as theme's menu links » Make menu block styling the same as theme's menu links in navigation region
Status: Needs work » Fixed

Fixed. http://drupalcode.org/project/zen.git/commitdiff/7591874

Thanks, Kris!

Automatically closed -- issue fixed for 2 weeks with no activity.