date_timezone_init attempts to access undefined variable [#1131916]

http://drupalcode.org/project/date.git/blob/refs/heads/6.x-2.x:/date_tim...

Variable $user is not defined in this context.

Comment	File	Size	Author
#1	1131916_date_timze_init-1.patch	734 bytes	hefox
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hefox CreditAttribution: hefox commented 11 July 2012 at 22:14

Status:

Active

» Needs review

File	Size
1131916_date_timze_init-1.patch	734 bytes

Considering this hook_init is broken and hasn't done anything for a long time, patch to remove it.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 11 July 2012 at 23:42

Status:

Needs review

» Reviewed & tested by the community

This code could never work and it hasn't been touched since 2008:

$ git blame date_timezone/date_timezone.module
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   1) <?php
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   2) /**
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   3)  * @file
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   4)  * This module will make the alter the user and site timezone forms to
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   5)  * select a timezone name instead of a timezone offset.
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   6)  *
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   7)  * This module won't be needed once core starts tracking timezone names
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   8)  * instead of offsets.
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000   9)  */
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000  10) 
96b9c7df (Karen Stevenson 2007-10-01 00:03:36 +0000  11) /**
24cd5e70 (Karen Stevenson 2008-03-01 18:06:39 +0000  12)  * Make sure a timezone has been selected.
24cd5e70 (Karen Stevenson 2008-03-01 18:06:39 +0000  13)  */
0f0850a6 (Karen Stevenson 2008-03-12 13:32:56 +0000  14) function date_timezone_init() {
0f0850a6 (Karen Stevenson 2008-03-12 13:32:56 +0000  15)   $tz_name = variable_get('date_default_timezone_name', NULL);
7f12b40f (Karen Stevenson 2008-05-08 15:08:11 +0000  16)   if (!empty($user->uid) && $_GET['q'] != 'admin/settings/date-time' && empty($tz_name)) {
4569f0ca (Karen Stevenson 2009-01-10 22:38:52 +0000  17)     drupal_set_message(t('The Date Timezone module requires you to <a href="@link">set the site timezone name</a>.', array('@link' => url('admin/settings/date-time'))), 'error');
24cd5e70 (Karen Stevenson 2008-03-01 18:06:39 +0000  18)   }
24cd5e70 (Karen Stevenson 2008-03-01 18:06:39 +0000  19) }