If you have a header and bottom pager, they have the same id. This cause 2 problems.
#1 - div with same ids is bad
#2 - the jquery function to add and remove the active class only adds and removes from the header pager (because it comes first)

You may say, well it was only attended for 1 pager to be used. In my scenario I am using 2 pagers. One is the content title, the other one is non-numeric pager, kinda like the one on lullabot.com.

CommentFileSizeAuthor
#4 1128930-d7-2.patch5.83 KBtom friedhof
#2 1128930-d7-1.patch2.04 KBredndahead
#2 1128930-d7-2.patch5.84 KBredndahead

Comments

redndahead’s picture

redndahead commented
Version: 7.x-3.0-alpha1 » 7.x-3.x-dev

I would say it is intended to have 2 pagers. So this is bad moving to dev so i will see it.

redndahead’s picture

redndahead commented
Status: Active » Fixed
StatusFileSize
new 1128930-d7-2.patch5.84 KB
new 1128930-d7-1.patch2.04 KB

This patch was committed with a follow up patch tracer.

tom friedhof’s picture

tom friedhof commented
Status: Fixed » Patch (to be ported)

Both patches from comment #2 did not make it into the last commit http://drupalcode.org/project/views_slideshow.git/commit/a7aa09b

The pager active class is broke using the latest dev version. I had to manually apply 1128930-d7-2.patch.

tom friedhof’s picture

tom friedhof commented
StatusFileSize
new 1128930-d7-2.patch5.83 KB

I re-rolled the patch from comment #2 (1128930-d7-2.patch) again so that it works with drush_make.

redndahead’s picture

redndahead commented

Whoops I had forgotten to push the commit. Can you make a patch for whatever you changed to get drush make to work?

BernieCram’s picture

BernieCram commented

Hi Redndahead,

I have just applied the patch in comment 4 and have found that it fixed the active class issues I commented about in this issue http://drupal.org/node/1144512#comment-4506724

Thanks so much to you for your work on this module and thanks tom for the patch!
Cheers
Bernie

tom friedhof’s picture

tom friedhof commented
Status: Patch (to be ported) » Fixed

@redndahead: I didn't make any changes, I just re-rolled the patch using --no-prefix so that the patch was in the correct format that drush_make expects.

@BernieCram: You shouldn't need to apply this patch if you grab the latest dev release dated June 14, 2011. @redndahead pushed this patch a couple days ago.

BernieCram’s picture

BernieCram commented

Thanks Tom, I should have checked for new dev, updated and all working as expected.
Cheers
Bernie

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.