Currently Single Sign-Out is enabled only if a user manually enables the option in the admin settings. I'd like to see us be good citizens and either

  1. Enable Single Sign-Out by default.
  2. Remove the checkbox & default to enabled. (This means that an admin could still do drush vset cas_signout 0 to disable it).
  3. Remove the checkbox and don't even allow admins to disable it.

Personally I think I prefer option 2 or 3, as they reduce the noise on the admin settings page.

CommentFileSizeAuthor
#2 1125460-Enable-Single-Sign-Out-by-default.patch3.41 KBbfroehle

Comments

metzlerd’s picture

metzlerd commented

If the code is stable, and given how long this has been in CAS Server. I'm quite ok with 3.

bfroehle’s picture

bfroehle commented
Status: Active » Needs review
StatusFileSize
new 1125460-Enable-Single-Sign-Out-by-default.patch3.41 KB

Here's a patch removing the option entirely. Let's see what the testbot says.

bfroehle’s picture

bfroehle commented
Status: Needs review » Fixed

Committed to 7.x-1.x and 6.x-3.x.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

As an user of the module, I agree with enabling Single Sign Out by default, but I don't think that 3) is a good idea without a good documentation on the subject.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f0678e0 on 7.x-1.x, 8.x-1.x by bfroehle: 
    Issue #1125460: Enable Single Sign-Out by default.