proper use of drupal_add_feed()

Moshe, help me: Which pages need such a link thing?

I don't think this is a problem any more, is it? It looks to me like the issue listings all have the RSS feed icon. Unless there's a page that's missing them that I can't think of let's mark this fixed.

Here is a simple patch rolled from a local SVN repository (but should apply to project_issue just fine). The issue here is that although the orange icons are added, the unified link tag based RSS referencing is not used. Using drupal_add_feed() results in the same visual output (Drupal adds in the orange feed icon), but it even allows other modules to collect feed information, display them differently; the theme to alter the presentation, etc. So using this is superior to just displaying an orange feed icon ourselves.

I think this patch/fix is quite straightforward. If you have a feed reading enabled browser like Firefox, Safari or IE7, after you applied this patch, it will offer the issue feed with its standard UI (unlike it did before the patch). I think this is a good improvement.

Goba pointed me to http://diveintomark.org/archives/2002/06/02/important_change_to_the_link... which has some extra information on what this change provides.

I tested the patch locally and it applies fine, with a bit of offset. The two changes I noticed are:
1. In my location bar on the right side I get the orange RSS icon when I'm at, for example, project/issues/project_issue
2. The orange feed icon is now on a line of its own, instead of being in line with the "#" used for the permalink. I think this looks ugly but I guess there's not anything we can do about that, since this is the default behavior of the theme.

I guess 2 isn't too big of a deal. The code looks good, so I don't see any reason not to commit this.

committed to 5.x-2.x and HEAD, deployed on d.o, et. all...

Superb, thanks!