user.api.php hook summary lines should be more consistent with other entity hooks

Updating the issue summary, after some digging this looks like a good novice documentation issue because the changes proposed are not massive.

Did changes in user.api.php documentation to make it more consistent like other core functions.

Thanks for taking this on @er.pushpinderrana :)

1. +++ b/core/modules/user/user.api.php
   @@ -371,11 +371,15 @@ function hook_user_view_alter(array &$build, \Drupal\user\UserInterface $account
   + * Note that when this hook is invoked, the changes have not yet been written to
   + * the database, because a database transaction is still in progress. The
   + * transaction is not finalized until the save operation is entirely completed.
   + *
   

   I don't think this is true for presave, at least not if you compare to hook_node_presave(). I don't think any transaction would be in progress at this point.

2. +++ b/core/modules/user/user.api.php
   @@ -390,7 +394,7 @@ function hook_user_role_presave($role) {
   - * Inform other modules that a user role has been added.
   + * Act on a user role being inserted or updated.
   

   "updated" doesn't apply to insert operations.

Looks at more of the examples in node.api.php "Respond to" also looks like an acceptable substitution for "Act on" if you wish.

It might be helpful to review #629518: hook_node_insert() and other node hooks have imprecise/misleading descriptions.

Incorporated your suggested changes in this patch. If something missing please suggest.

Looks good to me, certainly an improvement. Thanks!

Re-rolled #5 patch for D7 too. Please review once.

That's great but we need to get the 8.x patch in first and then backport once the status is "Patch (to be ported)" :)

https://www.drupal.org/contributor-tasks/backport

+++ b/.gitignore
@@ -4,3 +4,4 @@ sites/*/settings*.php
 # Ignore paths that contain user-generated content.
 sites/*/files
 sites/*/private
+/nbproject/private/
\ No newline at end of file

This should be removed from the D7 patch.

@Cottser, thankyou for guiding me.

I would surely removed these extra line code from D7 patch and tested manually, once the thread status come to "Patch (to be ported)".

Rerolled patch #7 for D7 and removed unused lines from this patch.

@Cottser, please suggest on this how to deal with this situation because D8 patch is still under review and D7 patch is going for automate testing. Not sure, how to avoid/remove D7 patch until D8 patch get fixed.

Sure :) This will not get committed to 7.x until it's committed to 8.x. It will not be committed to 8.x unless it is RTBC. So I suggest hiding the 7.x patches and waiting. You can hide patches from the issue summary using the files fieldset below the comment form.

Committers, #5 is the D8 patch here.

Committed 310065c and pushed to 8.x. Thanks!

Back to D7 for backport :)

Here is patch for D7. Please review.

Missed the version dropdown, patch looks good! Thanks @er.pushpinderrana.

Testbot failure.

Committed to 7.x - thanks!