user_role_save() doesn't implement a presave hook

Patch looks good, I'm not sure the hook should start with "Inform other modules", although that's from other comments in the same file so not for this patch to worry about.

This is just adding a hook that's missing (and it's silly to have insert/update hooks without presave), so it makes sense to me to backport it to D7.

Looks good to me.

Yep, we should clean up the docs in another issue all in one go, not here.

Feels like this needs a few comment tweaks...

+++ b/modules/user/user.api.phpundefined
@@ -367,6 +367,23 @@ function hook_user_view_alter(&$build) {
 /**
+ * Inform other modules that a user role is about to be saved.
+ *

Should be "Act on a user role being inserted or updated." to fit with existing first lines of exiting hook_entity/THING_presave()s.

+++ b/modules/user/user.moduleundefined
@@ -2821,6 +2821,9 @@ function user_role_save($role) {
+
+  module_invoke_all('user_role_presave', $role);
+
   if (!empty($role->rid) && $role->name) {
     $status = drupal_write_record('role', $role, 'rid');
     module_invoke_all('user_role_update', $role);

Let's add a comment here (again consistency with our other THING_save() comments):
// Let modules modify the user role before it is saved to the database.

Powered by Dreditor.

@Dave - the first one has already been discussed - the comments in user.api.php all need fixing, so we should open a separate issue to fix them in one go (or alternatively fix them all here but that's not really in scope).

I agree it's worth adding a comment by the module_invoke_all() though, so CNW for that at least.

Looks good, let's do comment cleanup in another issue.

Yeah I know the other docs need cleanup, just not sure why we can't make that change here for this function since its new...

The example is a bit silly. It would be helpful to have a helpful example. If not in the example code, maybe explain in the documentation _why_ this is a useful hook.

This patch looks fine, however I do agree with @skwashd in that using an example from uuid is too specific for an example.

However we do have issue #1120440 which is a clean up of user.api.inc so we should most likely revisit it there.

+1 RTBTC

This looks good.

Committed to 7.x and 8.x.