Comments

boombatower’s picture

Assigned:Unassigned» boombatower

Based on initial tests, seems like browser is not redirecting properly which is most likely due to dated version, can either update it or replace with browser module.

Current references:

./review/simpletest/pifr_simpletest.client.inc:90:    $b = new PIFRBrowser();
./review/drupal/pifr_drupal.client.inc:186:    $b = new PIFRBrowser();
./client/review/browser.inc:12:class PIFRBrowser {
boombatower’s picture

Status:Active» Needs review
StatusFileSize
new189.06 KB
Test request sent.
[ View ]

Swapped out browser for SimpleTest one since a lot cleaner that way.

boombatower’s picture

rfay, can we get this up on a testbot to see if it works ok then I'll commit and we can retest the actual patch.

boombatower’s picture

It actually should work if you drop out the .info and browser.inc changes. If so we can just do that if we don't want to do the whole SimpleTest road.

rfay’s picture

Why don't you commit what you want on a topic branch and then you can test and work with it.

I have a scratch testbot currently active, scratchtestbot.osuosl.test. You have root ssh and the testbot has the normal admin password. You also have administrator on rfay.redesign.devdrupal.org (PIFT) and of course qa.scratch.drupal.org.

You do have to do the setup required at http://supercell.osuosl.org/documentation/ssh and http://supercell.osuosl.org/documentation/httpproxy if you haven't already. I'm happy to help.

quicksketch’s picture

Any update here guys? I'd like to reroll the core directory patch, but I know it's just going to fail again.

rfay’s picture

@boombatower, this one is yours, right? You have access to the test testbot and everything... We can deploy this whenever it's been tested.

boombatower’s picture

I don't appear to have access to those documentation pages.

boombatower’s picture

Just to keep this up-to-date. Applied for accounts and waiting for activation.

https://support.osuosl.org/SelfService/Display.html?id=18891

quicksketch’s picture

Thanks boombatower, I appreciate your continued drive to get this done. This issue is beyond my knowledge sphere.

boombatower’s picture

StatusFileSize
new79.96 KB
Test request sent.
[ View ]

Attempted to run the last few /core move patches, but they won't apply. That is either true or something else is going on.

Test:
http://rfay.redesign.devdrupal.org/node/1119113
http://qa.scratch.drupal.org/pifr/test/126714

Test client:
http://qa.scratch.drupal.org/pifr/test/126694
http://ec2-184-72-191-248.compute-1.amazonaws.com

Update patch since last one had accidental browser2.inc.

rfay’s picture

@boombatower, can you apply them manually on that machine?

rfay’s picture

I confirmed in #22336: Move all core Drupal files under a /core folder to improve usability and upgrades that that patch doesn't apply. Sorry for the waste, boombatower. But at least we got you on a testbot. Thanks for doing that. I wonder if there's one there that does apply.

rfay’s picture

I confirmed in #22336-160: Move all core Drupal files under a /core folder to improve usability and upgrades that that patch doesn't apply. Sorry for the waste, boombatower. But at least we got you on a testbot. Thanks for doing that. I wonder if there's one there that does apply.

boombatower’s picture

StatusFileSize
new80.08 KB
Test request sent.
[ View ]

Tweak the assert method and did a couple hours worth or testing and what not locally.

boombatower’s picture

Status:Needs review» Fixed

Committed.

Recommend we deploy this.

rfay’s picture

Yay! Let's get it out there.

It's time to turn off -p0 patches too. Wonder if there's anything else we could sneak in.

This affects the testbots only, right? What are the risks, if any?

I probably won't be able to do any significant work on PIFR for two weeks, but might be able to do the patch change, and will be happy to help with deployment.

boombatower’s picture

Yea, this only effects clients and should have minimal risk since effects a very small portion of code.

rfay’s picture

There were a number of implications of this change to simpletest that caused installs to fail, etc.

Attached

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.