Rounded corners are dirty [#1118490]

See the attached image. There are some black pixels around the rounded corner. Tried to change the order of actions but same result.

Can this be the result of GD version I run? This is reported by admin/reports/status:

GD Image Filtering	Low Quality / Poor Performance
The installed version of PHP GD does not support image filtering(desaturate, blur, negate, etc). It was probably compiled using the official GD libraries from http://www.libgd.org instead of the GD library bundled with PHP. You should recompile PHP --with-gd using the bundled GD library. See PHP Manual for more information. A slower implementation of imagefilter() written in PHP will be used in the interim.

Comment	File	Size	Author
#4	imagecache_canvasactions-1118490.patch	2.46 KB	claudiu.cristea
#1	rounded.jpg	13.9 KB	claudiu.cristea
	icon.jpg	51.1 KB	claudiu.cristea

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 7 April 2011 at 09:43

File	Size
rounded.jpg	13.9 KB

Running the same actions on PHP 5.3 with GD 2 - no warnings in admin/reports/status

Same behavior with corners. See attached image.

Comment #2

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 7 April 2011 at 09:46

Title:

Rounded corners add some dirt in corners

» Rounded corners are dirty

Comment #3

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 7 April 2011 at 11:16

It seems that this is affecting corners where the cut is on transparent area

Comment #4

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 7 April 2011 at 13:55

Status:

Active

» Needs review

File	Size
imagecache_canvasactions-1118490.patch	2.46 KB

The bug consist in use of variable $rgba instead of $color. I added also a little performance improvement by checking if $color['alpha'] is not 127 and process pixels opacity only in that case. Otherwise pass 127.

Comment #5

InTheLyonsDen CreditAttribution: InTheLyonsDen commented 8 January 2012 at 18:50

I'm having the same issue with D7. Has anyone (or could anyone) adapt this patch for D7? Thanks!

Comment #6

dman CreditAttribution: dman commented 12 January 2012 at 04:24

I can replicate in D7.
I can confirm that the patch (applied by hand to D7) does fix it.
So cool. Thanks.
I can see why rounded corners on transparent input would not have been a test case :-)

#4 by claudiu.cristea, is now applied to D7-dev
http://drupal.org/commitlog/commit/6286/6158e6caadcaba8edbf5103483638900...
Raw patch for D7 here
http://drupalcode.org/project/imagecache_actions.git/blobdiff_plain/7544...

Comment #7

dman CreditAttribution: dman commented 12 January 2012 at 04:25

Status:

Needs review

» Closed (fixed)

Fix is only in -dev (not a stable yet) but I'll flag it as nominally done, there's a bunch of things in the queue I've got to chew through.

Comment #8

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 12 January 2012 at 08:20

Please commit also to D6. It's from April 2011! That patch is on production from then.

Comment #9

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 12 January 2012 at 08:26

Status:

Closed (fixed)

» Reviewed & tested by the community

Comment #10

InTheLyonsDen CreditAttribution: InTheLyonsDen commented 12 January 2012 at 16:55

The new dev version works great. I did have to resave the presets that were utilizing the rounded corners which is logical. Thank you!

Comment #11

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea commented 12 January 2012 at 17:39

I'm glad that works but, as finder of bug and author of patch, I would be very happy to have it pushed also in 6.x-1.x branch :-) It was applied and is successfully working on big production site since April 2011.

Thanks!