Use #access for user relationship mailer settings [#1116854]

Comment	File	Size	Author
#1	1116854.1-use_pound_access-6.x.patch	2.5 KB	deviantintegral
#1	1116854.1-use_pound_access-7.x.patch	3.37 KB	deviantintegral

Comment #1

deviantintegral commented 5 April 2011 at 13:59

Status:

Active

» Needs review

Status	File	Size
new	1116854.1-use_pound_access-7.x.patch	3.37 KB
new	1116854.1-use_pound_access-6.x.patch	2.5 KB

Here are two patches ready for git am.

Log in or register to post comments

Comment #2

berdir

German

Switzerland

commented 5 April 2011 at 14:04

Looks good, minor suggestion about the commit message, if you're using format-patch anyway. Start the commit message with "Issue #...." instead of "#" because the latter will be recognised as a comment when creating the commit message in an editor. Also, you can also directly add your name to it, for example: "Issue #111685 by deviantintegral: ...".

Then I don't need to edit the commit message at all :)

Log in or register to post comments

Comment #3

deviantintegral commented 8 April 2011 at 23:10

I usually use --cleanup=whitespace, or -m '#123: my awesome message.'

Were you editing the commits, and should I reroll with any changes? If you were planning on committing them as-is you shouldn't need to edit the commit message.