Hi guys
I'm having difficulties creating branches and releases (front page.module) and would like to be able to disable the module download links while I try and work out how to correctly tag updated files and/or create new releases and branches.
I've unpublished the releases attached to the project node, but, the download link to an old, known to be faulty, module version that I'm unable to update is still active.
Anyone know how to disable the download links on the module page?
I don't mind taking time out to work out how the new contributions system works, but, I think it's best that the module isn't downloadable until I've found time to do that.
cheers
Dub
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | project-browse-honor-release-hide-settings.patch.txt | 3.33 KB | dww |
| #4 | screen-shot-for derek.jpg | 181.66 KB | Dublin Drupaller |
Comments
Comment #1
Dublin Drupaller commentednever mind. I was able to unpublish the project and that removed it from the modules page.
Dub
Comment #2
Dublin Drupaller commentedJust to update this in case anyone else is having the same problem...
the option to disable RELEASE LINKS when you Edit a project ([PROJECT NAME] -> EDIT -> RELEASES doesn't work. When you disable releases, the DOWNLOAD link is still active when viewing the modules page.
I'll raise a seperate issue about that. Just thought I';d mention it on this issue as it's related.
It appears that the only way to disable the DOWNLOAD link for a module is to UN PUBLISH the release node. (go to [project name] -> EDIT and under publishing options, disable PUBLISHED)
Dub
Comment #3
dwwthe option to disable RELEASE LINKS when you Edit a project ([PROJECT NAME] -> EDIT -> RELEASES doesn't work. When you disable releases, the DOWNLOAD link is still active when viewing the modules page.
what are you talking about? ;) there's no such setting on the "Releases" subtab of the edit tab on project nodes. no wonder it doesn't work. maybe you're talking about this checkbox:
"Display snapshot releases on project page"
snapshot releases are development snapshots, as explained in gory detail here:
http://drupal.org/handbook/cvs/releases/types
see http://drupal.org/node/101887 for the issue about why that checkbox exists.
there's no setting regular project maintainers can control to disable download links on project nodes. as you apparently discovered, if you want to hide a release, you should have someone unpublish it (until http://drupal.org/node/90531 is implemented).
also, throughout your replies here, you're confusing release nodes with project nodes. project nodes are the home page of your project, like: http://drupal.org/project/front
release nodes represent a specific release, like: http://drupal.org/node/111780
release nodes are explained in gory detail here:
http://drupal.org/node/94151
good luck,
-derek
Comment #4
Dublin Drupaller commentedNope...I was referring to the ENABLE RELEASES option when editing a PROJECT. If you DISABLE RELEASES, the 'DOWNLOAD' link is still live.
I have attached a screenshot of what I see when editing a project.
Maybe it's a wording thing..but, disabling an ENABLE RELEASES option would give most the impression that you're disabling RELEASES from the project page. Which would be very useful if you don't want Drupal users to download old versions of a module and especially if you're having difficulties branching and tagging.
Anyone else stumbling across this issue, please note that the only way to disable module download links is to un-publish the project page. Un-publishing RELEASE NODES doesn't make any difference to the module page.
As an example, I was completely baffled yesterday because I had unpublished the RELEASE NODES for a project (to avoid Drupallers downloading old releases of a module while I was working out the new tagging/branching system) thinking that it would disable RELEASES and subsequently the DOWNLOAD links.
The DOWNLOAD link and releases disapeared, as they should, from the project page, but, if a person viewing the module page was filtering by a particular version, they would still see a download link for the unpublished RELEASE for that version.
I'm still not sure what the advanced options (see screen shot attached) actually do. My guess is that the code that generates the module page is ignoring whatever you have set for ENABLE RELEASES, i.e. it doesn't check to see if releases are available for a given project.
Anyway..I hope that helps others...that stumped me for ages yesterday and it wasn't until I went on to the #drupal channel that the guys there helped me out with the tag/branching problem.
Dub
Comment #5
Dublin Drupaller commentedSorry for opening this back up..but, I think this needs to be addressed.
An example of the 'download link' problem I'm doing my best to flag here is as follows:
I have added in a temporary note that most Drupal users should notice, until the correct release for Drupal 4.7.x is picked up by the site, but, I think this is pretty important for a number of reasons:
Not sure if that makes sense or not..or if I have missed something, but, I thought it might be better to flag it up here.
Like I said in the previous post, I'm guessing that the code that is generating the module page isn't checking to see what releases are actually published for that project..or whether the module maintainer has ENABLED RELEASES or not.
Hope that helps others.
Dub
Comment #6
dwwok, i'd believe that the crazy query that generates the module browsing pages could get these 2 things wrong. if so, it's a bug in project.module that would need investigation. reclassifying...
however, i suspect a big part of the problem is how much you're changing the major revision for front_page [1], since that's only supposed to happen rarely (if at all). it's a pretty bizzare combination of factors that lead to this bug, including having the default release series for your module (the value in the table on the "Releases" subtab of your edit tab) set to a version that has no published releases, etc. so, i'm downgrading the priority, too.
[1] http://drupal.org/node/112093
Comment #7
dwwComment #8
Dublin Drupaller commentedplease stop changing the title of this issue.
Thanks
Dub
Comment #9
dwwa) please stop abusing your "site maintainer" privileges or they'll be revoked. do NOT change the titles of issues via the edit tab, use a followup, like i'm doing. otherwise, people don't know when/why/or by whom the title was changed.
b) please stop setting the title back to something meaningless. i've attempted to clarify what the issue is, and reflect that in the title. it's not a "how do i do XXX?" support request anymore, i've already granted (though i haven't confirmed) there's actually a bug here. so, the title of the issue should explain the bug, not the particular support request that led to the bug.
-derek
Comment #10
Dublin Drupaller commentedno offense dww...There's no need to threaten anyone by the way.
but I checked with other Drupal developers on the #drupal channel and they confirmed the same observation I made.
I must remember in future not to bother posting possible problems.
Cheers
Dub
Comment #11
dwwi didn't say "don't report problems". i mean: "don't report them in inappropriate ways, or get in ridiculous pushing matches over the title of an issue with the person trying to help you".
anyway, back to "module browsing pages ignore release published status..." here's a patch. *sigh*
Comment #12
Dublin Drupaller commentedmust admit, I'm afraid I don't share your same attitude, Dww.
I wasn't looking for help, I was flagging a potential problem to help others. That's what I always thought contributers to Drupal did and I don't really get your "helping you" comment.
I've reset the title of this issue to be more accurate and helpful.
If you have a problem with that, you can go ahead and revoke whatever permissions I have on my account like you threatened earlier. The general attitude and atmosphere on here is sorta putting me off posting anyway so it won't really make much difference.
cheers
Dub
Comment #13
dwwyup, it's true, this is always happening, not just under the weird scenario i originally thought. new title is fine. thanks. bumping priority, too.
in terms of your "being put off" by the "atmosphere", i don't know what to tell you. you post a handful of confusing comments to handbook pages asking for help as support requests (which, after nearly 3 years of having a d.o account and however long you've had "site maintainer" privileges, you should know by now is a big no-no), you write some of fairly hostile-sounding issues with heavy use of ALL CAPS, etc. in spite of your past insults and attacks on me, i still tried to be courteous and help you deal with your confusion (and yes, the 1 bug buried among all the other support requests). when i tried to sort out the bugs from the confusion, you get in a pushing match over the title of an issue with the maintainer trying to resolve the problem (which, yes, is trying to help you, even if the bug effects other people, too), and you abuse your site maintainer privileges for no apparent reason (other than perhaps you didn't know any better).
i'm "put off" by the constant demands on my time to help people deal with a well-documented system that many developers seem to be able to handle just fine, and am *really* put off by people using the wrong channels to get support, especially if they should know better. please have a little consideration for the immense effort i'm putting out here, and excuse me if i lose my patience at times when dealing with confrontational replies where you're telling me i don't know how to use the issue queue.
i hope you can read the above with a sympathetic perspective and can actually hear what i'm saying, instead of chalking this up in your mind as another "dww-is-a-jerk" post...
-derek
Comment #14
Dublin Drupaller commentedIf you're taking a reported issue as some sort of attack on you personally, there's not a lot I can say, Derek.
The only thing I would ask of you is to please please please don't threaten people who are trying to help. There is no need for it.
I've been around long enough to let things like this slide, but, Drupal is dependent on a vibrant community that are encouraged, not scared, to help out. In future, when someone posts a problem, please check it out first to see if the problem actually exists before threatening them or flying off the handle.
As for the new contributions system..I'm obviously too thick to work it out, so don't worry about it.
I'll just pull back from contributing and look for a volunteer to help out in future. I'm not only tentative about updating any modules now, I'm also very nervous about posting an issue for fear of getting my head bitten off.
That's not a condusive atmosphere that enourages the community to engage and get involved. It took me a few hours to check the problem with the modules page and double check on the IRC channel to make sure it really was an issue. I imagine many others who took time out to try and help out might not have the same patience. As I say, I'm around long enough to let it slide, but, the community is too important and I'd prefer to nip this in the bud if I can. So, if you could please try and be less abrasive and threatening in future it would be appreciated.
As for the handbooks, please read the "contributing handbook pages" guidelines. If you are adding a handbook page and *don't* want people posting comments you should switch OFF comments for that handbook page. Otherwise, readers will assume that comments are welcome.
cheers
Dub
Comment #15
dww1) the personal attack i'm refering to are your forum posts months ago when i was trying to help you with your problems regarding your cvs account(s). i can dig up the link to the shameful forum post where you insulted and slandered me if you really want. yes, it's hard to find the kindness to keep helping you given that, but i tried anyway, and once again got burned.
2) i only lost my cool in comment #9, long after the bug was reported, and only because you were being inappropriate.
3) i only "threatened" you when you were misusing powers on the site, not because you tried to report a bug.
4) handbook page comments are controlled system-wide. yes, for people who don't know any better, it's a first line of defense for improving a page, but experienced site maintainers have better means.
5) please don't lecture me about fostering a vibrant community and encouraging participation. i've bent over backwards to help hundreds of people, yourself included, deal with their problems. maybe 0.05% of the time, i lost my patience and got a little upset. give me a break.
Comment #16
Dublin Drupaller commentedSeriously Derek. I really think you need to preview before posting. Is digging up an old post another veiled threat or is it supposed to be helpful in some weird way?
Please check the "contributing handbook pages" guidelines. Comments on handbook pages are not site-wide settings, you can disable comments for individual hand book pages.
If you're under pressure to get the new contributions system working properly because users have donated money to the initiative I can only suggest you take a break and come back to it refreshed. The Drupal community is very resourcefull and will struggle on despite the problems.
And please please please try and be a bit more diplomatic in future. As a community it's vital to encourage people to contribute...not alienate them, threaten them or bite their heads off.
Comment #17
merlinofchaos commentedDub, to be fair, I tried to help you on this too and you kind of skipped out and appeared not to fully take my advice. I'm not sure if it was misunderstanding the advice I gave or what, but I can understand Derek's position.
Please, let's relax. Derek has put in a LOT of work on this system, and he's been pretty overwhelmed by the response he's gotten. The fact that this system got as far as it did in the time that it did is *amazing*. Very, very few people have contributed to the level that Derek has. I'm perfectly willing to forgive him having a few rough edges while getting everything settled.
As for the patch here:
dww I can't really RTBC this; it's mostly changes to a query that I'm not going to be able to suss out just by looking at it; the code appears sound. All I can say is that if the new query works on s.d.o and the bug appears fixed, you're going to have to put this one through on your own =)
Comment #18
dwwcommited to HEAD and DRUPAL-4-7--2. installed on d.o.
Comment #19
(not verified) commented