Fatal error: Cannot unset string offsets

-    unset($items[$field['field_name'] .'_add_more']);
+    if(isset($items[$field['field_name'] .'_add_more']))
+        unset($items[$field['field_name'] .'_add_more']);

http://drupal.org/coding-standards#indenting Use two spaces instead of tabs.

http://drupal.org/coding-standards#controlstruct use {} in control structures. Control statements should have one space between the control keyword and opening parenthesis, to distinguish them from function calls.

http://drupal.org/coding-standards#concat Always use a space between the dot and the concatenated parts to improve readability.

And from http://drupal.org/node/34341 use !empty() instead of isset()

So, the code should be:

if (!empty($items[$field['field_name'] . '_add_more'])) {
  unset($items[$field['field_name'] . '_add_more']);
}   

Iv rolled the patch to use whats shown in #2.

Is this going to be accepted?

Me again,

It seems the Addresses module sends the following array to _content_field_invoke for $items:

... (Object) stdClass
data (Array, 1 element)
  0 (Object) stdClass
    data (Array, 5 elements)
      street (Object) stdClass
      city (Object) stdClass
      province (Object) stdClass
      postal_code (Object) stdClass
      country (Object) stdClass
  type (String, 6 characters ) struct
type (String, 5 characters ) array

Whilst the code expects an Array, this is throwing numerous errors on my site (and thus I am sure others)

Fatal error: Cannot use object of type stdClass as array in modules/cck/content.module on line 1248

So, Iv just changed the patch to first check if it is an Array, before unsetting $items[_add more]

I realise that at the end of this day, this is something that Addresses should check, but its probably a good idea for CCK to make sure its checking an array, before it trys to do anything to it. I hope this is ok.

Ignore my comments.

In your code, you should run
node_object_prepare($node);

before
node_save($node);

and then you shouldnt receive this error.

When I try to apply this patch, I get the error:

patching file content.module
patch: **** malformed patch at line 15:

-Jessi

I have the same issue on line 1248.

It may be linked to this issue : http://drupal.org/node/1077798

Closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.