Reserved SQL keywords being used [#1100896]

I was getting errors when analyzing tables like this:

# User warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;maxvalue) VALUES (33, &#039;tid&#039;, 0, 1, 1, 0, 0, 0, &#039;serial&#039;, 4, 142)&#039; at line 1 query: INSERT INTO tw_columns (twtid, colname, weight, primarykey, availablefk, secure, ignorecol, isempty, coltype, minvalue, maxvalue) VALUES (33, &#039;tid&#039;, 0, 1, 1, 0, 0, 0, &#039;serial&#039;, 4, 142) in _db_query() (line 148 of /Users/steverude/Documents/workspace/guitarworld.com/httpdocs/includes/database.mysqli.inc).
# User warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;maxvalue) VALUES (33, &#039;vid&#039;, 1, 0, 0, 0, 0, 0, &#039;int&#039;, 2, 7)&#039; at line 1 query: INSERT INTO tw_columns (twtid, colname, weight, primarykey, availablefk, secure, ignorecol, isempty, coltype, minvalue, maxvalue) VALUES (33, &#039;vid&#039;, 1, 0, 0, 0, 0, 0, &#039;int&#039;, 2, 7) in _db_query() (line 148 of /Users/steverude/Documents/workspace/guitarworld.com/httpdocs/includes/database.mysqli.inc).
# User warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;maxvalue) VALUES (33, &#039;weight&#039;, 4, 0, 0, 0, 0, 0, &#039;int&#039;, -10, 9)&#039; at line 1 query: INSERT INTO tw_columns (twtid, colname, weight, primarykey, availablefk, secure, ignorecol, isempty, coltype, minvalue, maxvalue) VALUES (33, &#039;weight&#039;, 4, 0, 0, 0, 0, 0, &#039;int&#039;, -10, 9) in _db_query() (line 148 of /Users/steverude/Documents/workspace/guitarworld.com/httpdocs/includes/database.mysqli.inc).

You are using minvalue and maxvalue as column names in tw_column. Per #141051: [Obsolete] List of SQL reserved words these are SQL reserved keywords. Need to change these to something else. I am changing these to minnumvalue and maxnumvalue in order to avoid the problem with name clashes with the SQL reserved keywords.

Please see attached patch.

Comment	File	Size	Author
#2	tw_1100896_2.patch	6.84 KB	slantview
#1	tw_1100896_1.patch	6.11 KB	slantview

Comments

Comment #1

slantview commented 22 March 2011 at 01:17

Status	File	Size
new	tw_1100896_1.patch	6.11 KB

Patch attached this time.

Comment #2

slantview commented 22 March 2011 at 01:29

Status	File	Size
new	tw_1100896_2.patch	6.84 KB

Ignore the last patch, needed to add update hook for changing existing tables.

Comment #3

slantview commented 22 March 2011 at 01:56

Status:

Active

» Needs review

Comment #4

slantview commented 15 April 2011 at 01:12

Bump. I know you don't want to work on this any more in favor of data module, but if you need someone to make the commits just give me git access and I'll update the module for you.