Currently the implementation of hook_footer() is always returning the markup for a div that is used by the javascript to present the popup confirmation dialogue. If the ajax setting is turned off, is there a reason to have this markup on the page at all? Users usually use css to make this div look how they want, and if ajax is turned off, this box shows up, empty.

Comments

sirkitree’s picture

Status: Active » Needs review
StatusFileSize
new805 bytes

The attached patch checks to make sure that the variable 'user_relationships_enable_ajax_popups' is actually set before returning this HTML.

mrf’s picture

Issue tags: +6.x-1.1

Looking at issues to include in 6.x-1.1

Status: Needs review » Needs work
Issue tags: -6.x-1.1

The last submitted patch, user_relationships-footer_markup_1100814.patch, failed testing.

mrf’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +6.x-1.1

The last submitted patch, user_relationships-footer_markup_1100814.patch, failed testing.

mrf’s picture

Status: Needs work » Needs review
StatusFileSize
new813 bytes

Think the first patch wasn't formatted correctly.

mrf’s picture

Status: Needs review » Fixed

Committed to 6.x-1.x-dev

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.1

Automatically closed -- issue fixed for 2 weeks with no activity.