Is this module still maintained and do you plan to port to D7? Thanks

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

voxpelli’s picture

I will probably port it - but unfortunately have no timeline for it - I have a lot of other more prioritized modules.

willmoy’s picture

Fair enough, thanks for the quick response. It's conceivable I might have some free time in a couple of months and will try to help out if so.

andypost’s picture

Title: Still maintained / D7? » Port Miltiping to Drupal 7
Status: Active » Needs work
FileSize
7.98 KB

This is a initial port.

Admin UI works, ping from UI works too.

Pinging logic should be refactored

1) _multiping_checkpings() - should accept a parameter of changed entity
2) _multiping_doping() - should accept second parameter a URL to ping

voxpelli’s picture

Can we have a patch? Also - change status to "needs review" when you feel you're ready for a review.

andypost’s picture

@voxpelli I just wanna to know maintainer's opinion before changing signature of main functions of the module.

I think that _multiping_doping($service, $options) should implement a ping Only and _multiping_checkpings($entity) should loop through services|settings and call _doping()

probably you have different vision so I'd like to know you opinion!

voxpelli’s picture

I think that we should refactor multiping. Although I'm also generally in favor of separating the refactoring from the porting so that both the D6 and the D7 version can get the advantages from the refactoring.

What should be done for this specific module I currently have no opinion on. I have a roadmap on http://drupal.org/project/multiping which I currently haven't had time to start on.

If you're able to separate out the refactoring into its own issue and provide patches for both D6 and D7 then that would be great. If not then I think I'll accept any patch anyway as long as it works.

andypost’s picture

@voxpelli I suppose it's better to start D7 version as 're-factored' because core have a lot of changes and then provide a upgrade path from D6.

Main reasons is about taxonomy that been slightly changed
- taxonomy vocabs are using machine_name so IDs is a thing of past
- taxonomy mostly a reference field and could be attached to any entity
- taxonomy now have only taxonomy/term/ID/feed

Also I think that better to start D7 branch to get more feedback from community before releasing a stable

voxpelli’s picture

@andypost: I think it would be very much possible to have similar version on D6 and D7 and I think that would be fairest to everyone. Of course an upcoming version can be unique to D7. But as as said - something is better than nothing, but don't change things just for the sake of changing - then we would have to either support two different modules or discontinue support for the D6 version.

sillygwailo’s picture

Title: Port Miltiping to Drupal 7 » Port Multiping to Drupal 7
Taxoman’s picture

Category: feature » task

Subscribing

Vydrin_AP’s picture

FileSize
2.93 KB

Hi there!
This is my Drupal7 ping solution.

Ping module

Taxoman’s picture

Hm. Why is that file not uploaded here but resides on a russian server?

Vydrin_AP’s picture

I don't know. That's why gave a link to the russian drupal community site.

voxpelli’s picture

If someone wants to take over as the maintainer of this module - then just say so and we'll try to arrange it.

Spleshka’s picture

I can help you with porting module to 7.x. Just give me access to git repository and I'll do the rest.

andypost’s picture

@Spleshka just provide a patch :) or use a sandbox

Spleshka’s picture

@andy, but I wanna to be a co-maintainer :)

openWeb’s picture

I am currently working on a port to d7...

will post patch againt the master-branch later this day

openWeb’s picture

FileSize
37.38 KB

Here we go... Patching master -> 7.x-dev (if you like to)...

"coder" gives no more errors or warnings, should overlook _multiping_checkpings to use the dbng-api, but could not do that in the time...

openWeb’s picture

Assigned: Unassigned » openWeb
Status: Needs work » Needs review
FileSize
37.38 KB

Setting correct status and new name for patch...

Spleshka’s picture

openWeb, try db_merge() instead of db_update() and db_insert(). It's more useful function.

voxpelli’s picture

I'm not going to have time to look into this - anyone want to be added as a co-maintainer?

Spleshka’s picture

Please add me. I'll make stable D7 release.

andypost’s picture

Status: Needs review » Needs work

Any reason to make this port many times? My patch in #3 mostly the same as @openWeb provides.
It uses core's approach to menu loaders and comment suggests to change a bit parameters for internal functions (prefixed with underscore)

+++ b/multiping.module
@@ -208,294 +149,426 @@ function _multiping_checkpings() {
+function multiping_ping() {
+  $id = arg(4);

use parameter - arg() as broken way.

+++ b/multiping.module
@@ -208,294 +149,426 @@ function _multiping_checkpings() {
+function multiping_delete() {
+  $id = arg(4);

same, take my code from #3

  $items['admin/config/services/multiping/%multiping_service/edit'] = array(
...
function multiping_service_load($id) {
...
function multiping_edit_service_form($form, &$form_state, $pingservice = array()) {
  //TODO: Add validation
...
+++ b/multiping.module
@@ -208,294 +149,426 @@ function _multiping_checkpings() {
-    $form['when_taxonomy'] = array(
+    $return['when_taxonomy'] = array(

do not change $form to $return - this function is a form builder

+++ b/multiping.module
@@ -208,294 +149,426 @@ function _multiping_checkpings() {
+    $results = db_select('multiping', 'm')
+                ->fields('m')

how many times you make direct queries to this table? I dont think that there's a lot of services in table so drupal_static is good pattern to go but dont forget to clean em

+++ b/multiping.module
@@ -208,294 +149,426 @@ function _multiping_checkpings() {
+    } ¶

a lot of trailing whitespace errors all over the patch, and there's some places with wrong indent

andypost’s picture

@Spleshka if you wanna maintain this please provide a patch

voxpelli’s picture

Assigned: openWeb » andypost

@anypost: Added you as a co-maintainer - if you need more co-maintainers then contact me and when you feel like you're ready to become a full maintainer then contact me.

andypost’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev

Initial version commited

7.x-1.x-dev release tarball upcoming

Things todo:
Upgrade path for taxonomy
- 6.x stores term->tid in service->voc but 7.x should save config per node-type to limit ping by term
- currently commited stub just hides taxonomy config in admin

Refactoring the ping model
- tremendous queries executed for each ping service just to find a changed and created nodes
- change ping to different signature _multiping_do_ping($service, $node)
- use queue to store jobs to ping
- depricate_multiping_checkpings() or change for queue generation

andypost’s picture

I'm going to start 7.x-2.x branch with breaking functionality into
global settings
- manage services
- link services to node types, probably just node-type checkboxes to allow per node settings
- ping frontpage on allowed node-types

per node settings
- node type form settings: pingable, limits
- node edit form: checkbox to ping on insert|update

Plazik’s picture

revagomes’s picture

Ping :P

I'm just posing a reminder to the maintainers to let people interested in this module to know when will be a D7 release version available to download. The maintainers can use this issue here to keep us followers posted on things like the progress made, if they needs a certain feature to be tested or when the next release is planned to be made.

quangtri’s picture

Issue summary: View changes

I think Multiping for drupal 7 is conflict with cron, ckeditor which make the cron could not run. The Ckeditor become dead white screen when save or update an old post. More importance it not ping when i save or update a post. Test drupal 7.38

voxpelli’s picture

Just a headsup here – I'm going to be looking into some updates to this module, either as a new 7.x-1.x version or as a 7.x-2.x version.

My primary focus will be to enable modern pinging mechanisms like Pubsubhubbub and to make it possible to easily integrate other parts of Drupal into such pinging and also to provide some such integrations.

I may also look into the legacy pinging as well as adding other modern pinging mechanisms like Webmentions.

voxpelli’s picture

Speaking of Webmentions – looks like https://www.drupal.org/project/vinculum has that and support many of the other ping types + is extendable. So even though I've maintained this module before, it looks like one would likely be better of moving the XML-RPC pinging that is at the core of this module to that one instead – and for me to make a patch for Pubsubhubbub to that module rather than as an extension of this one.

So – probably a change of plan to that unless it proves to not work.

  • andypost committed 0bea619 on 7.x-2.x
    Issue #1095740 by andypost, openWeb, willmoy: Port Multiping to Drupal 7...
voxpelli’s picture

Status: Needs work » Fixed

I've pushed a new major version of this module for Drupal 7 and released an alpha of that so I'm going to close this as fixed.

All remaining items to track before a stable 7.x-2.0 release can be made can be found in #2616616: Tracking issue for 7.x-2.0

jonathan1055’s picture

Hey that's great work. Thank you.

andypost’s picture

Assigned: andypost » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.