Closed (fixed)
Project:
Memcache API and Integration
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Mar 2011 at 22:53 UTC
Updated:
2 Feb 2017 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
catchPatch isn't attached ;)
Comment #2
jtsnow commentedDoh! Here it is.
Comment #3
catchComment #4
jcfiala commentedI think this is a pretty good idea - we've just hit on a situation where we need the same sort of functionality.
Here's our patch, targeted at d7.
Comment #5
cyberswat commentedIt's probably nit-picky, but I'd suggest something that doesn't use the empty() checks ... maybe something like the following would ultimately be more performant?
Comment #6
jcfiala commentedAfter a bit of back and forth locally, here's an updated patch:
Comment #7
jcfiala commentedAnd apparently I failed to hit save after making my changes...
Comment #8
jcfiala commentedAnd apparently I am an idiot today.
Comment #9
cyberswat commentedI like this approach because it explicitly sets the prefix passed in to NULL so that it can't be mistaken for a legitimate cache prefix and should perform marginally better.
Comment #10
marcingy commentedThe patch is for d7 so bumping to there to solve confusion.
Comment #11
cyberswat commentedif ($prefix == NULL) {should beif ($prefix === NULL) {Comment #12
jcfiala commentedUpdated the patch to reflect cyberswat's not in comment 12:
Comment #14
jeremy commentedSorry for the slow review.
I've rewritten the logic to use the existing prefix variable for maximum flexibility.
The feature is currently documented as follows: