I am just trying resolve a random bug so decided to run some modules through the Coder module to eliminate that as a possible issue. Saw few issues with the D7 version that would be great to get into an upcoming release.

CommentFileSizeAuthor
#1 webform_coder-d6.patch53.75 KBquicksketch
#1 webform_coder-d7.patch53.86 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new webform_coder-d7.patch53.86 KB
new webform_coder-d6.patch53.75 KB

I've been meaning to do this for a while anyway, but here are patches that make the obvious changes in code style for D7 that we should be using. Because I maintain D6 and D7 in sync, I've committed all of these changes to both 3.x branches so that patches apply easily between the two branches. This should pass with 100% compliance on strict mode, minus about a dozen false positives.

quicksketch’s picture

quicksketch
he/him
commented
Title: Coder Review » Coder module compliance and D7 style updates
Category: feature » task
mgifford’s picture

mgifford
he/him
Primary language English
commented

That's great! Thanks for doing this. This is a very useful module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.