the map does not render properly when under a vertical tab

CommentFileSizeAuthor
#20 gmap-1064448-20-vertical_tab_fix.patch902 bytesmstrelan
#19 gmap-1064448-19-vertical_tab_fix.patch1.12 KBmstrelan
#18 gmap-1064448-18-vertical_tab_fix.patch645 bytesmstrelan
#14 1064448.patch638 bytespodarok
#12 D7_gmap_hack_for_vertical_tabs-1064448-12.patch627 bytesnclavaud
#8 1064448_8_gmap_hack_for_vertical_tabs.patch517 bytesgiorgosk
#2 vertical_tabs_1064448_2.patch589 byteskndr
#1 vertical_tabs_1064448_2.patch568 bytesgiorgosk

Comments

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented
Status: Active » Needs review
StatusFileSize
new vertical_tabs_1064448_2.patch568 bytes

solution using collapsehack

apply patch
enable collapsehack in admin/settings/gmap
and clear cache and refresh page

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new vertical_tabs_1064448_2.patch589 bytes

Thanks. This trick is working for me. I couldn't apply #1 to the latest gmap-6.x-1.x-dev, so I upload recreated patch.

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented

you had to apply patch from the root directory
that is the reason the patch did not apply
otherwise both patches are identical

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

the changes works also for me.

bryancasler’s picture

bryancasler commented

Will this work for D7?

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented

its a very simple patch (if you open the patch with notepad you will see a single line addition)
you can learn how to read a patch file (http://drupal.org/node/367392)
and try the changes on the 7 version
hopefully it works

sylvaincharles’s picture

sylvaincharles commented

For all who wonder how to get the collapsehack work in vertical tabs in Drupal 7:
just replace $('.vertical-tab-button').children............. from the D6 patch above
with : jQuery('.vertical-tab-button').children.....
Bonne chance

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented
StatusFileSize
new 1064448_8_gmap_hack_for_vertical_tabs.patch517 bytes

New patch for the latest 6.x dev version
please review and report back

identical to previous patches above but line numbers have changed

adr_p’s picture

adr_p commented

The method worked for me.

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented

#2 #4 #8 #9 report this to be working for them
please patch this

seemas’s picture

seemas commented

Patch works for me too. Just for DRUPAL 7 read #7

nclavaud’s picture

nclavaud commented
StatusFileSize
new D7_gmap_hack_for_vertical_tabs-1064448-12.patch627 bytes

My patch for D7.

jQuery('.vertical-tab-button', jQuery(elem).parents('.vertical-tabs')).children('a').click(r);

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs work

#12

git apply --check D7_gmap_hack_for_vertical_tabs-1064448-12.patch
warning: js/gmap.js has type 100644, expected 100755
error: patch failed: js/gmap.js:357
error: js/gmap.js: patch does not apply

needs reroll against latest dev

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs work » Fixed
StatusFileSize
new 1064448.patch638 bytes

rerolled against latest dev

commited / pushed to all 7.x branches

thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Slacker’s picture

Slacker commented

I have a clean install of latest version Drupal (7.22) with ctools (7.x-1.3), location (7.x-3.0-rc1), gmap (7.x-2.6) and still doesn't show correctly in vertical tab. Can anybody help me?

Slacker’s picture

Slacker commented
Status: Closed (fixed) » Active
mstrelan’s picture

mstrelan commented
StatusFileSize
new gmap-1064448-18-vertical_tab_fix.patch645 bytes

Hey Slacker, I have the same problem. It seems that the attached patch works for me, although it seems to be centering to the wrong co-ordinates. That may be some other configuration issue though.

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
StatusFileSize
new gmap-1064448-19-vertical_tab_fix.patch1.12 KB

Centering issue should be resolved in this patch. Seemed to be caused by the call to map.setCenter() when the map isn't visible. Not sure if there's a better solution though. Tested this with a gmap both inside and outside of vertical tabs.

mstrelan’s picture

mstrelan commented
StatusFileSize
new gmap-1064448-20-vertical_tab_fix.patch902 bytes

Patch in #19 doesn't center correctly if a marker is already set, eg when editing a node that already has a location. This patch works in and out of vertical tabs, centers correctly on default location and centers correctly on already populated locations.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

#20: gmap-1064448-20-vertical_tab_fix.patch queued for re-testing.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Fixed

#20 commited pushed to 7.x-2.x
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.