Currently (2007/01/02), Zeitgeist still installs by hand. The zeitgeist.install file is only used for upgrades. A complete install file à la Drupal 5 would be a plus.

This feature has already been tackled twice with incomplete results, but patches submitted were not satisfying. Here are the links to the issues, in case someone feels like creating this install file:

CommentFileSizeAuthor
#1 zeitgeist.install.patch1.24 KBjaydub

Comments

jaydub’s picture

jaydub commented
Version: master » 4.7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new zeitgeist.install.patch1.24 KB

Ok I've taken a stab at it. Included PostgreSQL support as well.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Needs work

Hi Jaydub,

Thanks for your work. Although I don't know much about PGSQL, I think the logic for the check is incomplete: you perform two queries in a row, inserting the results in an array, and only check whether the array is not NULL, which will be true even if only one of the two queries worked (presumably the first one).

Once this is corrected, I think the patch will be good to be committed, especially if you also add an implementation for hook_uninstall.

jaydub’s picture

jaydub commented

For processing the results of the queries in the .install file, I just copied examples from other module .install files. Feel free to take a look at other modules - some of which run multiple queries - and see if it's done any differently. As for hook_uninstall, I am not running 5.x series yet (where hook_unistall is supported) so I'll have to leave that up to someone else.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Fixed

Fixed and included in today's version.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)