user_save fails in sf_user_import()

Hi Aaron,

I added this at the very beginning of sf_user_import():

watchdog('sf_user_import', 'sf_data <pre>%sf_data</pre> name <pre>%name</pre> uid <pre>%uid</pre>',
array('%sf_data' => print_r($sf_data, TRUE), '%name' => $name, '%uid' => $uid), WATCHDOG_NOTICE, null);

Here is the sanitized output when sf_user_import is invoked by sf_notifications.

sf_data:

stdClass Object
(
    [Id] => 003Q000000HipCnIAJ
    [AccountId] => 001Q000000HotySIAR
    [Contact_Type__c] => %%%%%%%%%
    [CreatedById] => 0054000000166ygAAA
    [CreatedDate] => 2011-02-14T22:27:23.000Z
    [DoNotCall] => false
    [Do_Not_Mail__c] => false
    [Drupal_ID__c] => 213131474
    [Educator_Status__c] => 5
    [Educator_Status_number2__c] => 5.0
    [Email] => %%%%%%%%%
    [FirstName] => %%%%%%%%%
    [HasOptedOutOfEmail] => false
    [IsDeleted] => false
    [LastModifiedById] => 0054000000166ygAAA
    [LastModifiedDate] => 2011-02-15T04:00:06.000Z
    [LastName] => %%%%%%%%%
    [LeadSource] => Website
    [OwnerId] => 005400000017ul0AAA
    [Owner_Email__c] => %%%%%%%%%
    [Owner_First_Name__c] => %%%%%%%%%
    [Owner_Full_Name__c] => %%%%%%%%% %%%%%%%%%
    [Owner_Last_Name__c] => %%%%%%%%%
    [SystemModstamp] => 2011-02-15T04:00:06.000Z
    [Valid_Credit_Card__c] => false
    [npe01__HomeEmail__c] => %%%%%%%%%
    [npe01__Preferred_Email__c] => Personal
    [npe01__Private__c] => false
    [npe01__SystemAccountProcessor__c] => One-to-One
    [npe01__SystemIsIndividual__c] => false
    [npe01__Type_of_Account__c] => Organization
    [npo02__Formula_HouseholdMailingAddress__c] => <br>,
    [npo02__SystemHouseholdProcessor__c] => All Individual Contacts
)

name: c4ca4238a0b923820dcc509a6f75849b
uid: 

As you can see 'uid' is NULL.

Here is the fieldmap for Contact to User object:

$salesforce_field_map = new stdClass;
$salesforce_field_map->disabled = FALSE; /* Edit this to true to make a default salesforce_field_map disabled initially */
$salesforce_field_map->name = 'c4ca4238a0b923820dcc509a6f75849b';
$salesforce_field_map->automatic = 6;
$salesforce_field_map->drupal = 'user';
$salesforce_field_map->salesforce = 'Contact';
$salesforce_field_map->description = '';
$salesforce_field_map->fields = array(
  'LastName' => 'profile_last_name',
  'Contact_Type__c' => 'profile_contact_type',
  'Credit_Card_Validated__c' => 'profile_last_cc_validation',
  'Download_Titles__c' => 'profile_download_log',
  'Drupal_ID__c' => 'uid',
  'Educator_Status__c' => 'profile_edstatus',
  'Email' => 'name',
  'FirstName' => 'profile_first_name',
  'HasOptedOutOfEmail' => '',
  'HomePhone' => 'profile_home_phone',
  'Last_Logged_In__c' => 'login',
  'Library_Access__c' => '',
  'MailingCity' => 'profile_address1_city',
  'MailingCountry' => 'profile_address1_country',
  'MailingPostalCode' => 'profile_address1_zip',
  'MailingState' => 'profile_address1_state',
  'MailingStreet' => 'profile_address1_street',
  'MobilePhone' => 'profile_mobile_phone',
  'Name' => '',
  'Online_Access__c' => '',
  'OtherPhone' => 'profile_other_phone',
  'Owner_Email__c' => 'profile_owner_email',
  'Owner_First_Name__c' => 'profile_owner_first_name',
  'Owner_Last_Name__c' => 'profile_owner_last_name',
  'Preferred_Address_Status__c' => 'profile_address1_type',
  'Salutation' => 'profile_salutation',
  'Shipping_City__c' => 'profile_shipping_city',
  'Shipping_Country__c' => 'profile_shipping_country',
  'Shipping_Postal_Code__c' => 'profile_shipping_zip',
  'Shipping_State__c' => 'profile_shipping_state',
  'Shipping_Street_Address__c' => 'profile_shipping_street',
  'Title' => 'profile_title',
  'Valid_Credit_Card__c' => 'profile_valid_cc',
  'npe01__HomeEmail__c' => 'profile_personal_email',
  'npe01__PreferredPhone__c' => 'profile_preferred_phone',
  'npe01__Preferred_Email__c' => 'profile_preferred_email',
  'npe01__Primary_Address_Type__c' => 'profile_address1_type',
  'npe01__WorkEmail__c' => 'profile_work_email',
  'npe01__WorkPhone__c' => 'profile_work_phone',
  'of_Paths__c' => 'profile_paths',
  'of_Visits_Last_2_Mo__c' => 'profile_site_visits',
);

I added another watchdog statement right before the attempt is made to insert a new user (when sf_user_import is invoked by creating a new Contact in Salesforce that is sent via outbound messaging to the Drupal site):

  // If the user exists, update the existing user.
  if ($account->uid) {
    $account = user_save($account, $changes);
    $create = FALSE;
  } else {
    watchdog('sf_user', 'updating <pre>%account</pre>, changes <pre>%changes</pre>', array('%account' =>
print_r($account, TRUE), '%changes' => print_r($changes, TRUE)));
   $account = user_save(null, $changes);
    $create = TRUE;
  }

Here is the sanitized output:

<?php

	updating

stdClass Object
(
    [uid] => 0
    [name] => 
    [pass] => 
    [mail] => 
    [mode] => 0
    [sort] => 0
    [threshold] => 0
    [theme] => 
    [signature] => 
    [created] => 0
    [access] => 0
    [login] => 1292576691
    [status] => 0
    [timezone] => 
    [language] => 
    [picture] => 
    [init] => 
    [data] => a:2:{s:11:"lead_source";s:7:"Website";s:7:"contact";i:1;}
    [timezone_name] => 
    [signature_format] => 4
    [lead_source] => Website
    [contact] => 1
    [roles] => Array
        (
            [1] => anonymous user
            [9] => %%%%%%
            [10] => library access
        )

    [profile_first_name] => first123
    [profile_last_name] => last123
    [profile_personal_email] => 
    [profile_address1_type] => 
    [profile_address1_street] => 
    [profile_address1_city] => 
    [profile_address1_state] => 
    [profile_address1_zip] => 
    [profile_address1_country] => 
    [profile_other_phone] => 
    [profile_mobile_phone] => 
    [profile_home_phone] => 
    [profile_preferred_phone] => 
    [profile_title] => 
    [profile_work_email] => 
    [profile_work_phone] => 
    [profile_preferred_email] => Personal
    [profile_site_visits] => 1
    [profile_organization] => first123 last123
    [profile_last_cc_validation] => 0
    [profile_fh_office] => North America
    [profile_email_opt_in] => 1
    [profile_roles] => 
    [profile_school_type] => 0
    [profile_salutation] => Mr.
    [profile_changed] => 1274573165
    [profile_contact_type] => 
    [profile_owner_email] =>  %%%%%%
    [nodewords] => Array
        (
        )

    [salesforce] => stdClass Object
        (
            [sfid] => 003Q000000Hiqr1IAB
            [name] => c4ca4238a0b923820dcc509a6f75849b
        )

    [sf_user_skip_export] => 1
)

, changes

Array
(
    [profile_last_name] => NUserTest
    [profile_last_cc_validation] => 0
    [name] => testusern@localhost.com
    [profile_first_name] => TestUserN
    [login] => 0
    [profile_owner_email] =>  %%%%%%
    [profile_personal_email] =>  %%%%%%
    [sf_user_skip_export] => 1
)

Looking at this I notice that the values for profile_first_name and profile_last_name are different in $account and $changes; I'm not sure why that is occurring.

If I modify the code in sf_user_import according to the patch provided at the beginning of this issue, a new Drupal user will be created successfully.

If I don't do that, the "else" is never evaluated and if I modify the code so that it is, calling user_save(NULL, $changes) results in duplicate key entry errors.

If you want, take the array for "changes" that is output above and try calling user_save(NULL, $changes) on a local test environment to see what happens.

One thing I can see about your testing via drush is that you are calling sf_user_import with the Salesforce ID rather than with an object of Salesforce data, so that is one potential reason why we are getting different results.

Finally, I am not using sf_prematch as it was causing some issues (mis-matching Drupal user IDs and SF IDs), and I did not need it for the project I'm working on at the moment.

Thanks for your help, let me know if there is any other information I can provide.

I reverted back to the latest code from 6.x-2.x-dev and applied your patch Aaron.

Here is the result from updating a Contact in Salesforce:

Duplicate entry '' for key 'name' query: INSERT INTO users (login, created) VALUES (0, 1297975994) in modules/user/user.module on line 327.

Followed by:

SalesForce Notificaitions failed to update user from record.

Array
(
    [name] => c4ca4238a0b923820dcc509a6f75849b
    [oid] => 0
    [sfid] => 003Q000000Hiqr1IAB
    [drupal_type] => user
    [fields] => stdClass Object
        (
            [Id] => 003Q000000Hiqr1IAB
            [AccountId] => 001Q000000HowvyIAB
            [Contact_Type__c] =>  %%%%%%%%%%
            [CreatedById] => 005400000017QYPAA2
            [CreatedDate] => 2011-02-15T15:42:55.000Z
            [DoNotCall] => false
            [Do_Not_Mail__c] => false
            [Drupal_ID__c] => 213131479
            [Educator_Status__c] => 3
            [Educator_Status_number2__c] => 3.0
            [Email] => %%%%%%%%%%
            [FirstName] =>  %%%%%%%%%%
            [HasOptedOutOfEmail] => false
            [IsDeleted] => false
            [LastModifiedById] => 005400000017ul0AAA
            [LastModifiedDate] => 2011-02-17T20:52:53.000Z
            [LastName] =>  %%%%%%%%%%
            [Last_Educator_Status_Change_Date__c] => 2011-02-15
            [LeadSource] => Website
            [MailingCity] =>  %%%%%%%%%%
            [MailingCountry] =>  %%%%%%%%%%
            [MailingPostalCode] =>  %%%%%%%%%%
            [MailingState] =>  %%%%%%%%%%
            [MailingStreet] =>  %%%%%%%%%%
            [Model_Teacher__c] => false
            [Online_Access__c] => true
            [Organization_Name_for_Mailing__c] =>  %%%%%%%%%%
            [Organization_Name_for_Mailing_formula__c] =>  %%%%%%%%%%
            [Organization_Site__c] =>  %%%%%%%%%%
            [OwnerId] => 005400000017ul0AAA
            [Owner_Email__c] =>  %%%%%%%%%%
            [Owner_First_Name__c] =>  %%%%%%%%%%
            [Owner_Full_Name__c] =>  %%%%%%%%%%
            [Owner_Last_Name__c] =>  %%%%%%%%%%
            [Preferred_Address_Status_Flag__c] => Address Status Flag
            [Preferred_Address_Status__c] => Good Address
            [Salutation] => Mr.
            [SystemModstamp] => 2011-02-17T20:52:53.000Z
            [Title] => tester
            [Valid_Credit_Card__c] => false
            [npe01__HomeEmail__c] =>  %%%%%%%%%%
            [npe01__Preferred_Email__c] => Personal
            [npe01__Primary_Address_Type__c] => Work
            [npe01__Private__c] => false
            [npe01__SystemAccountProcessor__c] => One-to-One
            [npe01__SystemIsIndividual__c] => false
            [npe01__Type_of_Account__c] => Organization
            [npe01__Work_Address__c] => %%%%%%%%%%
            [npo02__Formula_HouseholdMailingAddress__c] => 
,
            [npo02__SystemHouseholdProcessor__c] => All Individual Contacts
        )

    [operation] => update
)

Here is the result from creating a new Contact in Salesforce, which should result in a new Drupal user being created.

Duplicate entry '' for key 'name' query: INSERT INTO users (login, created) VALUES (0, 1297976302) in modules/user/user.module on line 327.

Followed by SalesForce Notificaitions failed to update user from record. and the same array of data that I pasted above. The relevant bit is that oid is 0.

Then I remembered you asked to delete any items from salesforce_object_map where oid is 0. There was one record that I removed. I tried to update a Contact and got this result:

Duplicate entry '' for key 'name' query: INSERT INTO users (login, created) VALUES (0, 1297976654) in modules/user/user.module on line 327.

Followed by "SalesForce Notificaitions failed to update from record." and the array, the interesting bit is this:

    [oid] => 
    [name] => c4ca4238a0b923820dcc509a6f75849b
    [drupal_type] => 

So neither oid nor drupal_type are set.

Can you please take another look at the initial patch I provided at the beginning of this issue? Because in my testing that patch resolves the issue for both inserting and updating users from Salesforce Contacts and Leads.

@dpearceMN: I ended up implementing hook_salesforce_api_pre_import and hook_salesforce_api_post_export to deal with these issues.

In my implementation of salesforce_api_pre_import, I set some values of the object being imported.

  if (!$object->uid) {
    // If the object doesn't have a user ID, then we need to insert a new user
    // Before doing so, some values need to be populated before user_save is called
    $object->uid = NULL;
    $object->name = $sf_data->FirstName . ' ' . $sf_data->LastName;
    $object->init = $sf_data->Email;
    $object->mail = $sf_data->Email;
    $object->status = 0; // If a status changes between $object and $changes, user_save should trigger an e-mail notification to the new user
    $object->pass = $pass = user_password();
    $changes['init'] = $sf_data->Email;
    $changes['uid'] = NULL;
    $changes['name'] = $sf_data->FirstName . ' ' . $sf_data->LastName;
    $changes['mail'] = $sf_data->Email;
    $changes['status'] = 1;
    $changes['pass'] = $pass;
  }  

At this point none of the profile fields are saved, however, and a link between the newly created user and the Salesforce object hasn't been established in {salesforce_object_map}. So in salesforce_api_post_import I have:

  if ($create && !salesforce_api_get_id_with_sfid($sf_data->Id)) {
    salesforce_api_id_save('user', $object->uid, $sf_data->Id, $name);
    // Call sf_user_import to grab any profile fields we missed the first time
    sf_user_import($sf_data->Id, $name, $object->uid);
    // This is a heavy operation, but necessary to: 
    //  - Ensure the user is not blocked
    //  - Ensure the SF object has the Drupal ID
    sf_user_export($object->uid, $name, $sf_data->Id);
    $sql = 'UPDATE {users} SET status = 1 WHERE uid = %d';
    $ret = db_query($sql, $object->uid);
  }

As you can see this is fairly cumbersome. But, the code successfully creates a new user with the profile fields defined in the fieldmap when a new Salesforce Contact is created.

The only major issues I'm having at this point are that

1. The status of the newly-created user is set to 'blocked', despite my SQL query in the post import hook
2. SF notifications is giving Duplicate entry for key 'name' on users that already exist; instead of updating the existing Drupal user object from modifications to a Salesforce contact, the code is attempting to insert a new user and failing because user_save is getting duplicate key entry errors.

I also agree that patch in #7 is reasonable. I'm still getting the duplicate entry errors in sf_user_import though. I will try to track that down soon.

I would like to commit the patch in #7 to dev, are there any objections?

I tested the patch in #7. When I try to visit user/%uid/salesforce and run an "Import changes from Salesforce" I get:

Fatal error: Cannot access empty property in /home/websites/mysite/live-docs/includes/bootstrap.inc on line 718

In bootstrap.inc, we have

/**
 * Unserializes and appends elements from a serialized string.
 *
 * @param $obj
 *   The object to which the elements are appended.
 * @param $field
 *   The attribute of $obj whose value should be unserialized.
 */
function drupal_unpack($obj, $field = 'data') {
  if ($obj->$field && $data = unserialize($obj->$field)) {
    foreach ($data as $key => $value) {
      if (!isset($obj->$key)) {
        $obj->$key = $value;
      }
    }
  }
  return $obj;
}

Any ideas?

Yes, I have a fields column. Here is the schema:

+-------------+------------------+------+-----+---------+----------------+
| Field       | Type             | Null | Key | Default | Extra          |
+-------------+------------------+------+-----+---------+----------------+
| fieldmap    | int(10) unsigned | NO   | PRI | NULL    | auto_increment | 
| drupal      | varchar(32)      | NO   |     |         |                | 
| salesforce  | varchar(32)      | NO   |     |         |                | 
| action      | varchar(32)      | NO   |     |         |                | 
| automatic   | smallint(6)      | NO   |     | 0       |                | 
| fields      | text             | NO   |     | NULL    |                | 
| description | varchar(255)     | YES  |     | NULL    |                | 
| name        | varchar(255)     | YES  | UNI | NULL    |                | 
+-------------+------------------+------+-----+---------+----------------+

I will try to look into this some more today if I have time.

Here is some more info on the issue: https://drupal.org/node/767512#comment-2843034

Looks like the problem is with saving an empty key in the user data. Later versions of Drupal core should prevent the error from occurring, but since the site I'm working on is 6.14, I need to ensure that no attempts at saving empty keys are made.

I was just working on this and came up with the same thing. The patch fixes my error message, and addresses the field importing issues described earlier in the thread. I think it is ready to commit. Thanks!

Patch in #22 is committed to dev. http://drupalcode.org/project/salesforce.git/commit/62aaeba

Do we want to leave this issue open to deal with questions raised in #15?