We now only have one field on {versioncontrol_operations} for date, and we need two as we are assuming that we store author and committer independently, so it should be the same for dates.

PS: this started as an sdboyer comment on IRC

Comments

marvil07’s picture

Assigned: Unassigned » marvil07
Category: bug » task
Issue tags: +versioncontrol-6.x-2.0-release-blocker

Well, not really a bug, but something we really want for 2.0 IMHO.

I am starting a patch that would replicate the information on the {versioncontrol_operations}.date to have two fields: author_date and commiter_date.
Backends should modify the values later, on a hook_update_n().

marvil07’s picture

Assigned: marvil07 » Unassigned
Status: Active » Needs work
StatusFileSize
new3.98 KB

Ok, here the first step: schema change and operation class data members change.

TODO: Change views implementation and default views.

marvil07’s picture

Assigned: Unassigned » marvil07
marvil07’s picture

Status: Needs work » Fixed
StatusFileSize
new14.51 KB

Finally getting this ready.

I pushed the attached patch that:

    - Schema change on {versioncontrol_operations} to use two fields for the
      dates.
    - Change operation class data members accordingly.
    - Change views definition for operation dates.
    - Change a little how the versioncontrol_handler_field_operation_date
      views field handler work in order to support the handling of both
      author_date and comitter_date.
    - Change default views definitions on commitlog module to follow the new
      views fields, author_date and committer_date.

Update: I forgot to mention that we need to change default views on all dependent projects(i.e. versioncontrol_git, versioncontrol_project)

marvil07’s picture

marvil07’s picture

I 've just pushed a follow up to fix tests.

Status: Fixed » Closed (fixed)
Issue tags: -versioncontrol-6.x-2.0-release-blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 8a69d02 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1054436: Store commit date and authoring date.
    
    - Schema change...
  • Commit c2e6488 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1054436 follow-up: Fix operation date change on tests.
    
    
  • Commit f121977 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07:
    Issue #1054436 follow-up: Fix date fields used on views feeds and its...

  • Commit 8a69d02 on 6.x-2.x, repository-families by marvil07:
    Issue #1054436: Store commit date and authoring date.
    
    - Schema change...
  • Commit c2e6488 on 6.x-2.x, repository-families by marvil07:
    Issue #1054436 follow-up: Fix operation date change on tests.
    
    
  • Commit f121977 on 6.x-2.x, repository-families by marvil07:
    Issue #1054436 follow-up: Fix date fields used on views feeds and its...