It has way too much important logic for it to be a theme function. And it only affects the fallback page. And it just complicates the code.

CommentFileSizeAuthor
#4 fullcalendar-1049028-4.patch3.96 KBtim.plunkett
#2 fullcalendar-1049028-2.patch3.57 KBtim.plunkett
#1 fullcalendar-1049028-1.patch3.58 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
fullcalendar-1049028-1.patch3.58 KB

Initial patch. Likely depends on #1047962: Deprecate custom display plugin in favor of custom empty text and #1043222: Remove the node (load) dependency, which are going in soon anyway.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
fullcalendar-1049028-2.patch3.57 KB

Alright, this one applies now that those two are committed.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Tested and works fine, code looks good

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Needs review
FileSize
fullcalendar-1049028-4.patch3.96 KB

I did more work on this, so that the fallback uses the date formatter chosen on the field's Manage Display.
The calls to date functions are so strange because date module is so strange. See #1049210: State of the Date module API.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » aspilicious
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Good to go, and a nice fallback.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Cool.
http://drupal.org/cvs?commit=494760

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Patch (to be ported) » Fixed

Out of necessity, I rolled this into #1036444: Cleanup the views UI + remove autodiscovery mega issue..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.