Invalid argument supplied for foreach() in MemCacheDrupal->getMultiple() [#1048546]

I get the following warning when doing "drush cc all" on a site using memcache:

php: Warning: Invalid argument supplied for foreach() in MemCacheDrupal->getMultiple() (line 31 of /home/subhub/core3/sites/all/modules/memcache/memcache.inc).

This appears to be from a cache miss - $mc->getMulti() returns false inside dmemcache_get_multi(), and then this result gets fed to a foreach in MemCacheDrupal::getMultiple().

The attached patch ensures that dmemcache_get_multi returns an empty array instead of false for a cache miss.

Comment	File	Size	Author
	memcache_invalid_arg_foreach.patch	392 bytes	rupertj

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rupertj CreditAttribution: rupertj commented 2 February 2011 at 11:26

Actually, I think I've described the issue slightly wrong - it can return false on failure, rather than on a cache miss: http://php.net/manual/en/memcached.getmulti.php

Comment #2

joshk CreditAttribution: joshk commented 8 April 2011 at 17:39

Seeing this quite a lot on sites. Patch works for me.

Comment #3

muschpusch CreditAttribution: muschpusch commented 5 May 2011 at 12:16

Status:

Needs review

» Reviewed & tested by the community

please commit! I get this on node edit pages... The patch works...

Comment #4

jghyde CreditAttribution: jghyde commented 1 July 2011 at 01:37

Tested the patch memcache_invalid_arg_foreach.patch listed above after running into this problem in Views 3 and D7. It works! The problem I encountered was in the Views UI. Comment or commit!

Joe