Whilst trying to track down an apparently disappearing theme, I've done some re-installing from scratch, and found oddities in the install procedure which are absolutely reproducible with freshly downloaded and installed Drupal (6.20), phpBB3 (3.0.8) and phpbbforum (6.x-2.0-rc1)

- Undocumented dependency on Profiles module. It may not _actually_ be a dependency, but if Profiles hasn't been enabled, there's a big scary red error message box displayed at the top of the module settings page.

user warning: Table 'drupal_db.profile_fields' doesn't exist query: SELECT DISTINCT(fid) as fid, name, title FROM profile_fields ORDER BY weight in /var/www/html/drupal-6.20/sites/all/modules/phpbbforum/phpbbforum.admin.inc on line 420.

Enable Profiles, and it goes away.

- 3.0.8 patch errors. When the patch is run against a freshly installed 3.0.8, several hunks fail.

[root@(hostname) phpBB3]# patch -p0 < phpBB-embed-3.0.8.patch 
patching file ./faq.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./faq.php.rej
...
patching file ./includes/functions_module.php
Hunk #1 FAILED at 2.
1 out of 3 hunks FAILED -- saving rejects to file ./includes/functions_module.php.rej
...
patching file ./includes/mcp/mcp_ban.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_ban.php.rej
patching file ./includes/mcp/mcp_forum.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_forum.php.rej
patching file ./includes/mcp/mcp_front.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_front.php.rej
...
patching file ./includes/mcp/mcp_notes.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_notes.php.rej
patching file ./includes/mcp/mcp_pm_reports.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_pm_reports.php.rej
...
patching file ./includes/mcp/mcp_warn.php
Hunk #1 FAILED at 2.
1 out of 4 hunks FAILED -- saving rejects to file ./includes/mcp/mcp_warn.php.rej
patching file ./includes/session.php
patching file ./includes/ucp/ucp_confirm.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./includes/ucp/ucp_confirm.php.rej
...
patching file ./includes/ucp/ucp_pm.php
Hunk #1 FAILED at 1.
1 out of 7 hunks FAILED -- saving rejects to file ./includes/ucp/ucp_pm.php.rej
...
patching file ./mcp.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./mcp.php.rej
...
patching file ./report.php
Hunk #1 FAILED at 2.
1 out of 2 hunks FAILED -- saving rejects to file ./report.php.rej
...
patching file ./viewonline.php
Hunk #1 FAILED at 2.
1 out of 4 hunks FAILED -- saving rejects to file ./viewonline.php.rej

(All successful patches snipped for clarity)

All the .rej files are essentially identical -

***************
*** 2,8 ****
  /**
  *
  * @package mcp
- * @version $Id: phpBB-embed-3.0.8.patch,v 1.1 2010/11/24 20:46:09 vb Exp $
  * @copyright (c) 2005 phpBB Group
  * @license http://opensource.org/licenses/gpl-license.php GNU Public License
  *
--- 2,8 ----
  /**
  *
  * @package mcp
+ * @version $Id: phpBB-embed-3.0.8.patch,v 1.1 2010/11/24 20:46:09 vb Exp $
  * @copyright (c) 2005 phpBB Group
  * @license http://opensource.org/licenses/gpl-license.php GNU Public License
  *

whereas the .orig file, lines 2-8, reads...

/**
*
* @package mcp
* @version $Id$
* @copyright (c) 2005 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*

Not the end of the world, but doesn't give the rosiest of feelings in the install process...

I've tried beta12/3.0.7PL1 (again, fresh downloads) and the patch works fine, but the Profiles error is still there.

CommentFileSizeAuthor
#3 phpBB-embed-3.0.8-patch-fix.diff1.39 KBAdrianC-1

Comments

Toxid’s picture

The patch works without errors for me. I use TortoiseSVN to patch. Which program do you use?

AdrianC-1’s picture

Version: 6.x-2.0-rc1 » 6.x-2.0-rc2

Still present in RC2

Toxid,

I'm using the command line patch from the install text file.

patch -p0 < phpBB-embed-3.0.8.patch

AdrianC-1’s picture

Status: Active » Needs review
StatusFileSize
new1.39 KB

OK, I've had a rummage around in the RC2/3.0.8 patch file, and - with these changes - it's now patching clean 3.0.8 without any error messages.

DropDeadFred’s picture

You are the man. Still an issue in RC2, but this diff worked for me. Thx.

fizk’s picture

Status: Needs review » Closed (fixed)