Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When viewing the commitlog, links to files that were deleted cause internal server error
Testing issue: #1040026: Clicking a file in the commitlog results in a File Not Found error
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | do-not-link-to-deleted-items.patch | 902 bytes | marvil07 |
| #3 | 0001-bug-1040030-by-marvil07-eliza411-Do-not-link-to-dele.patch | 1.18 KB | marvil07 |
Comments
Comment #1
eliza411 commentedTo reproduce: http://git-dev.drupal.org/node/21106/commits
Try any deleted file http://git-dev.drupalcode.org/project/node_type_filter.git/blob/00cc1621...
Comment #2
marvil07 commentedI think i know why.
In gitweb webviewer_url_handler plugin I used git blob, that is only set for non-deleted files, but the plugin used in git-dev is gitweb_rewrite, that support pathinfo gitweb feature, that use hashes, that are always set(no depent on the blob).
So, I suppose I need to verify deletion, hopefully is not that hard :-p
Comment #3
marvil07 commented\o/ I really enjoy when fixes are simple :-)
Fix committed.
Comment #4
eliza411 commentedStill seeing the error after the Jan 26 build.
Comment #5
marvil07 commentedYep, the problem is still there because the default webviewer plugin is still the one defined by drupalorg module, that is not necessary anymore.
So, not sure where that's set. Looking for it
Comment #6
sdboyer commented@marvil07 - I shifted us back to a drupalorg-specific plugin so that we could handle the necessary prefixing for project/ vs. sandbox/[git username]. It was mildly hacky having that in the base url in the first place. Regardless, that plugin is working now, but we'll need a similar change made to it. I think I should be able to adapt this patch...
Comment #7
marvil07 commentedOk, here the same hunk applied to drupalorg related module.
Comment #8
sdboyer commentedFixed. Thanks!
Comment #9
eliza411 commentedNow there are no links on deleted files, yay!
But the links to existing files produce 404s.
See To reproduce: http://git-dev.drupal.org/node/21106/commits to reproduce. Click any file link.
Comment #10
eliza411 commentedI should add that there were changes to gitweb that could be the problem.
Comment #11
eliza411 commentedThis morning, they're working fine.