Closed (fixed)
Project:
Version Control API -- Git backend
Version:
6.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
20 Jan 2011 at 14:19 UTC
Updated:
26 Mar 2014 at 15:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marvil07 commentedThanks for reporting this.
I was talking with mikey_p about it yesterday, but I could not reproduce it with gitweb webviewer_url_handler plugin(A slightly different plugin is used on git-dev).
Anyway I going to take another look at this, but in local, since AFAIK I do not have permissions to check configuration on git-dev.
Comment #2
marvil07 commentedAfter sdboyer gave me enough permission, I see in the repo configuration that it does not have a base url, so I think the problem is how the repositories are created.
sdboyer told me the place was drupalorg-git, so I made a patch, and made a pull request on github.
Comment #3
marvil07 commentedSam accepted the pull request, so it should be fixed in the next build, but actually change the status after checking it on git-dev.
BTW #1027356: Provide a way to set default plugins for repositories is more less related.
Comment #4
mikey_p commentedMarco, thanks for the fix for base_url, that was a known issue, but there is still a bug where the HASH is wrong
I.e. on the link from the page in the OP: http://git-dev.drupal.org/commitlog/commit/b95bd6af8990056f5ccb9d2736365... on drupal.org
The webviewer_handler plugin generates a link to:
http://git-dev.drupalcode.org/project/panels_960gs.git/blob/499e8a50bc76...
This page is broken and is using the WRONG hash.
The correct link is:
http://git-dev.drupalcode.org/project/panels_960gs.git/blob/b95bd6a:/css...
Notice that the hash is the same hash as the commit itself.
Comment #5
marvil07 commentedOk, I think I got the problem.
I am using a gitweb in local that is not using friendly URLs(at local it is using a lot of GET parameters).
I have also taken a look to places like http://repo.or.cz where gitweb is running with friendly URLs, but I did not really even try them :-p, but the solution is clear, the hash would need to be the commit hash and not the blob in that case, so it would be pretty simple to change it.
I am going to:
Comment #6
marvil07 commentedOk, here the patch that completes the work of the plugin defined on drupalorg, so it can be just removed when this gets in.
Comment #7
sdboyer commentedThanks marvil07. Committed - sorry, we need it in and couldn't wait.