The link on the hash tag and file name are missing their base_url. The user name is link working fine. (And the logs are looking good!)

To reproduce:
on http://git-dev.drupal.org/commitlog/commit/b95bd6af8990056f5ccb9d2736365...
hash = http://panels_960gs.git/commit/b95bd6a
file link = http://panels_960gs.git/blob/6ad39554165fc1599e125ed3422e7f262d122d35%3A...

Comments

marvil07’s picture

Assigned: Unassigned » marvil07

Thanks for reporting this.

I was talking with mikey_p about it yesterday, but I could not reproduce it with gitweb webviewer_url_handler plugin(A slightly different plugin is used on git-dev).

Anyway I going to take another look at this, but in local, since AFAIK I do not have permissions to check configuration on git-dev.

marvil07’s picture

Project: Version Control API » The Great Git Migration
Version: 6.x-2.x-dev »
Component: Commit Log » Migration scripts

After sdboyer gave me enough permission, I see in the repo configuration that it does not have a base url, so I think the problem is how the repositories are created.

sdboyer told me the place was drupalorg-git, so I made a patch, and made a pull request on github.

marvil07’s picture

Sam accepted the pull request, so it should be fixed in the next build, but actually change the status after checking it on git-dev.

BTW #1027356: Provide a way to set default plugins for repositories is more less related.

mikey_p’s picture

Project: The Great Git Migration » Version Control API
Version: » 6.x-2.x-dev
Component: Migration scripts » API module
Priority: Normal » Major

Marco, thanks for the fix for base_url, that was a known issue, but there is still a bug where the HASH is wrong

I.e. on the link from the page in the OP: http://git-dev.drupal.org/commitlog/commit/b95bd6af8990056f5ccb9d2736365... on drupal.org

The webviewer_handler plugin generates a link to:
http://git-dev.drupalcode.org/project/panels_960gs.git/blob/499e8a50bc76...

This page is broken and is using the WRONG hash.

The correct link is:
http://git-dev.drupalcode.org/project/panels_960gs.git/blob/b95bd6a:/css...

Notice that the hash is the same hash as the commit itself.

marvil07’s picture

Ok, I think I got the problem.

I am using a gitweb in local that is not using friendly URLs(at local it is using a lot of GET parameters).

I have also taken a look to places like http://repo.or.cz where gitweb is running with friendly URLs, but I did not really even try them :-p, but the solution is clear, the hash would need to be the commit hash and not the blob in that case, so it would be pretty simple to change it.

I am going to:

  • make another plugin "Gitweb friendly URLs" that only change the file view( __please__ tell me if it is needed in other case).
  • make a little patch to use it at drupalorg
marvil07’s picture

Title: Link on hash tag and file name are broken » Add new gitweb-rewrite webviewer plugin for pathinfo gitweb feature
Project: Version Control API » Version Control API -- Git backend
Component: API module » Code
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new4 KB

Ok, here the patch that completes the work of the plugin defined on drupalorg, so it can be just removed when this gets in.

sdboyer’s picture

Status: Needs review » Fixed

Thanks marvil07. Committed - sorry, we need it in and couldn't wait.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 9

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 22d3e84 on 6.x-2.x, fix-invalid-default-branches, fullsync-memory by sdboyer:
    Issue #1033918 by marvil07: Introduce a new gitweb url handler that...