$.domready() may fire before jQuery is loaded

This is discussed at https://github.com/getify/LABjs/issues/16 and it affects both 6.x and 7.x branch. The fix could be quite easy: the jquery_update way! This module replaces drupal.js with its own version. I'll roll a patch in the next few days when I have time.

If anyone wants to test first:
- In this module change $LAB.executeQueue(); to

$LAB.queue(function() {
  $(document).trigger("scripts-ready");
}).executeQueue();

- Then change your misc/drupal.js. In D7, replace this block (I removed comments)

$(function () {
  if (jQuery.support.positionFixed === undefined) {
    var el = $('<div style="position:fixed; top:10px" />').appendTo(document.body);
    jQuery.support.positionFixed = el[0].offsetTop === 10;
    el.remove();
  }
});
$(function () {
  Drupal.attachBehaviors(document, Drupal.settings);
});

with

$(document).bind("scripts-ready", function(){
  if (jQuery.support.positionFixed === undefined) {
    var el = $('<div style="position:fixed; top:10px" />').appendTo(document.body);
    jQuery.support.positionFixed = el[0].offsetTop === 10;
    el.remove();
  }
  Drupal.attachBehaviors(document, Drupal.settings);
});

This is untested, however.

We'll fix it in D7 first. I've committed a patch that does exactly what I said in #3. A small problem with overlay: when I click to a link, the hash change, new page is loaded by Ajax, but just right after that, the URL changes. This problem does not always happen, and I haven't found the cause.

#6 is separated into a new issue: #1050866: Intermittent problem with overlay.module. I consider it is fixed in 7.x. The rest is backporting to 6.x.

No, it is not the same thing. Please open new issue, with as much detail as possible.

Yes, user with addavg enabled can profit pre alter to change drupal.js. Even without advagg, I think I can borrow from jquery_update.module to replace this file.

This a a diff for D7 drupal.js in #6. I haven't work in D6, but it should be the same.

--- ../d7/misc/drupal.js	2011-01-22 19:07:08.000000000 +0700
+++ ../d7/sites/all/modules/contrib/labjs/drupal.modified.js	2011-01-23 04:31:48.000000000 +0700
@@ -1,4 +1,4 @@
-// $Id: drupal.js,v 1.72 2011/01/01 04:11:39 webchick Exp $
+// $Id: drupal.modified.js,v 1.1 2011/01/22 21:31:48 jcisio Exp $
 
 var Drupal = Drupal || { 'settings': {}, 'behaviors': {}, 'locale': {} };
 
@@ -350,7 +350,7 @@ document.cookie = 'has_js=1; path=/';
 /**
  * Additions to jQuery.support.
  */
-$(function () {
+$(document).bind('scripts-ready', function(){
   /**
    * Boolean indicating whether or not position:fixed is supported.
    */
@@ -359,10 +359,8 @@ $(function () {
     jQuery.support.positionFixed = el[0].offsetTop === 10;
     el.remove();
   }
-});
 
-//Attach all behaviors.
-$(function () {
+  //Attach all behaviors.
   Drupal.attachBehaviors(document, Drupal.settings);
 });

You'll need to fire the scripts-ready event, too. It needs a patch for labjs.module. I'm really busy now, but I'll commit that code.

Ok, finally get it done. It's be more reasonable to fix LABjs issue in LABjs module ;)

Sure.

In this special case I think you'll patch LABjs so that if advagg is enabled, LABjs won't replace drupal.js, is it what you plan to do? Then in AdvAgg, use the drupal.modified.js instead ;)

I'm learning Git, too. Thanks for the patch. Reviewed, tested and committed. I'll let you close #1082612: LABjs compatibility .

SocialNicheGuru, how to reproduce it? I tested with Views 3.1 with a few actions and I didn't have any problem.