Needs to add revision arguement to title.

CommentFileSizeAuthor
#5 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch2.08 KBmarvil07
#2 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch2.08 KBmarvil07
#1 1030266-revision_name_in_title-1.patch1001 bytesmikey_p

Comments

mikey_p’s picture

mikey_p commented
Status: Active » Needs review
StatusFileSize
new 1030266-revision_name_in_title-1.patch1001 bytes

This is one approach although I'm afraid this would cause the view to run twice, but I'm not really sure how else to go about this.

marvil07’s picture

marvil07 commented
StatusFileSize
new 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch2.08 KB

Related #1024960-14: Need view for individual commit message.

Based on the patch at #1024960-14: Need view for individual commit message I am using views title.

The only bad thing I see is that the revision argument is not passed in "short" format, but I think that's not so bad, and in that way we are using views feature for titles.

We could have the short version of revision, but I just wanted to avoid loading more entities if not really needed.

mikey_p’s picture

mikey_p commented
Status: Needs review » Reviewed & tested by the community

This pretty much looks good, I think we should make the per-user commit view should use the same approach, but we can fix that after this goes in.

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Needs work

Patch fails to apply. Please reroll.

marvil07’s picture

marvil07 commented
Assigned: mikey_p » marvil07
Status: Needs work » Fixed
StatusFileSize
new 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch2.08 KB

Yep, not applying anymore since an upstream change.

Re-rolling and committing it.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 9

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 9

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 4428d59 on repository-families, drush-vc-sync-unlock by marvil07: 
    task #1030266 by mikey_p, marvil07: Single commit view should use...

  • Commit 4428d59 on repository-families by marvil07: 
    task #1030266 by mikey_p, marvil07: Single commit view should use...