Needs to add revision arguement to title.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch | 2.08 KB | marvil07 |
| #2 | 0001-task-1030266-by-mikey_p-marvil07-Single-commit-view-.patch | 2.08 KB | marvil07 |
| #1 | 1030266-revision_name_in_title-1.patch | 1001 bytes | mikey_p |
Comments
Comment #1
mikey_p commentedThis is one approach although I'm afraid this would cause the view to run twice, but I'm not really sure how else to go about this.
Comment #2
marvil07 commentedRelated #1024960-14: Need view for individual commit message.
Based on the patch at #1024960-14: Need view for individual commit message I am using views title.
The only bad thing I see is that the revision argument is not passed in "short" format, but I think that's not so bad, and in that way we are using views feature for titles.
We could have the short version of revision, but I just wanted to avoid loading more entities if not really needed.
Comment #3
mikey_p commentedThis pretty much looks good, I think we should make the per-user commit view should use the same approach, but we can fix that after this goes in.
Comment #4
sdboyer commentedPatch fails to apply. Please reroll.
Comment #5
marvil07 commentedYep, not applying anymore since an upstream change.
Re-rolling and committing it.