Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Over in #513096-83: The Future of Image in Drupal 7, we're currently trying to figure out the future of Image module components and features.
One of them is an old and basically unmaintained version of the ImageMagick toolkit support, which ImageAPI also provides. AFAIK, ImageAPI has been moved into core for D7.
I've just contacted the owner of http://drupal.org/project/imagemagick and requested a project takeover, which originally was a GSOC project that was never completed, Heine told me in IRC. If he doesn't respond within the next days, I'm going to take over the project as intermediate maintainer (don't plan to do anything with it though).
There is however a dev snapshot of ImageAPI for D7, which (also) contains code for ImageMagick support, and other stuff, status unclear. It is quite possible that instead of moving Image module's code into the ImageMagick project, it makes more sense to move ImageAPI's code instead.
Comments
Comment #1
drewish CreditAttribution: drewish commentedYou should be able to just drop the ImageMagick code and rely on ImageAPI's version. It should fully implement the D7 image API along with some enhancements. IIRC the SoC project has a totally different interface and wouldn't be compatible.
Comment #2
sunJust discussed with @drewish in IRC...
IMHO, it would still be a good idea to take over the ImageMagick to form a proper and dedicated project for ImageMagick integration on drupal.org. Lots of users find that project page through searching/googling, and the ImageAPI project page doesn't really make clear that it's the primary (and working) integration project currently.
In any case, we're going to remove all ImageMagick support code from the Image project for D7, leaving this part entirely to the ImageAPI and/or ImageMagick project.
I know that @dman has been quite active in Image module's queue, too — though not sure whether he actually is a ImageMagick power-user. When moving the code into the ImageMagick project, it would make sense to form a team of ImageMagick experts as maintainers (which totally does not include myself).
Keeping this issue open for @dman's feedback.
Comment #3
andypostis there ability to uniform approaches to adding|replacing engines like imagemagick to D7 core?
I think generalized API is preffered but I scare that using imageAPI+(imagemagick or whatever library) is wrong way most of sites preffere only one way to process image files. The same about video transcoding...
IMO, having DrupalCacheInterface in Core is a way to go for Image Processing too
Comment #4
quicksketchYes, Drupal core's image handling is completely swappable and makes the existence of ImageAPI as a project unnecessary in Drupal 7. Drupal core includes what currently is called "ImageAPI GD" directly in core, making a similar project for GD unnecessary. The only part of of ImageAPI that is not in core is "ImageAPI ImageMagick", which is why it would make sense to move the remaining functionality to a dedicated project and bring the ImageAPI project to a close.
On the project page ImageAPI notes that it provides an "Unsharpen mask". This should probably be moved to ImageCache Actions (though that project needs to be renamed also).
Comment #5
pyrollo CreditAttribution: pyrollo commentedAll this sounds very good. I have been thinking of something like that when I saw the ImageAPI code for Drupal 7. It could be nice and more understandable to have a IM Toolkit specific module.
Comment #6
sunAfter ~2 weeks without reply, I went ahead and kick-started re-initialization of the http://drupal.org/project/imagemagick project.
Going to do an initial merge/migration of functionality now.
Comment #7
sunThe ImageMagick project contains fully working code for D7 now. See #1045454: Initial merge/migration from ImageAPI for all changes of the merge/migration process.
Comment #8
andypostProject page needs to be updated about D7 new http://drupal.org/project/imagemagick module
Comment #9
pyrollo CreditAttribution: pyrollo commentedI had quickly tested this new module and it works well.
There are two minor issues :
- When switching from imageapi_imagemagick to imagemagick, imagemagick toolkit is not selected anymore (actually, no toolkit is selected).
- The Imagemagick module is not in any package (falling back into "Others"). It may be a good thing to have an "Imagemagick" package to put other modules like IM_Raw.
Comment #10
sun@pyrollo: The first issue you encountered should be fixed with the patch in #1045454: Initial merge/migration from ImageAPI
Please keep further issues you find in the proper queue; i.e., http://drupal.org/project/issues/imagemagick
Comment #11
fietserwinGood to read that you have made a decision on the future of the toolkit.
Recent weeks I have made quite some improvements in the D7 imagemagick part of both the imageapi and the imagecache_actions projects. Any chance that the following errors/suggestions can make it to the imagemagick project?
#1046084: imagemagick toolkit: allow imagecache_action: convert format
#1021850: Rotate with empty background color does not yield a transparent background
#1021690: No error feedback as convert returns 0 even with error messages on stderr
#1019534: Warning: proc_open(): CreateProcess failed, error code - 267 in _imageapi_imagemagick_convert_exec() (regel 204 ...
Any info on what the imagecache_actions project is going to do?
How can I help? (I don't have cvs access and I don't want to, as I'm not going to master a system that will be phased out in 15 days. Locally, I am on Mercurial, so git will be fine I guess.)
Comment #12
Fidelix CreditAttribution: Fidelix commentedSubscribing...
Comment #13
sunWould be nice if we could add a pointer to http://drupal.org/project/imagemagick on ImageAPI's project page.
Since there is a D7 branch here, people still report bugs and submit patches for the ImageMagick toolkit here, instead of using the already working implementation from http://drupal.org/project/imagemagick
Comment #14
andypostI think module should mention about it's successor ImageMagick module on it's front page.
Currently usage statistics point that imageAPI 7.x has more installs as ImageMagick
Comment #15
fietserwinEven better: set the D7 branch to unsupported as that better reflects the actual situation...
Comment #16
sakthipriyadevakumar CreditAttribution: sakthipriyadevakumar commentedneed video tutorial or step by step clear and updated documentation of pdf preview...because i cannot work with image magick and pdf preview.....i followed the steps given in the page of pdf preview module... i have tried several times..but it is not working...please help me out soon......
Comment #17
quicksketchSince there hasn't been any activity in this queue from the maintainer, I've updated the project page per this issue's recommendations. Thanks @sun for the separate ImageMagick project, everything makes more sense that way.
Comment #18
sunThanks! :)
Note that I'm still seeking for co-maintainers for http://drupal.org/project/imagemagick, who are versed in ImageMagick, Drupal core's image toolkit API, PHP shell/sub processes, and ideally also cross-platform/environment (Linux/Mac/Windows) development to move that project forward.
There are patches. There's community interest. There are improvement suggestions.
But WEIRDOSCHIZOPHRENICANOIA, I do not even have a Drupal site myself that uses ImageMagick right now, but yet, I'm maintaining that project! :-o ;)
That said, I just granted git access to everyone who is listed on the project page already; wasn't aware that this wasn't the case yet.
If anyone else is interested, make sure to check the best practices for co-maintaining projects and get involved! :)
Thanks,
sun
Comment #19
andypostSuppose 7.x branch (currently 9,642 installs) should be unpublished and probably some issues about 7.x moved to ImageMagick project queue (currently 5500 installs)