The CKEditor is missing the button for the internal iFrame plugin.

This is a default function that CKEditor supports.
http://ckeditor.com/demo

A quick try didn't help to make Wysiwyg support this feature. Any idea what was missing?

CommentFileSizeAuthor
#6 wysiwyg.HEAD_.ckeditor-iframe.1025296.6.patch947 bytestwod
#4 wysiwyg.HEAD_.ckeditor-iframe.1025296.4.patch586 bytestwod

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev

This seems related:
http://dev.ckeditor.com/ticket/4648

While it should be part of 3.5 i still see a "MISSING" comment in the sources when grepping for iFrame.
EDIT: "MISSING" seems to refer to missing translation for the matches.

Also the release blog talks about iframes support:
http://ckeditor.com/blog/CKEditor_3.5_released
And here is the full iframe documentation
http://docs.cksource.com/CKEditor_3.x/Users_Guide/Rich_Text/IFrame

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

Thanks for creating an issue about this, I know this new iFrame plugin is part of the latest release but I have not yet had time to add support for it to ckeditor.inc.
It should be a pretty small change, Wysiwyg just needs to be told the plugin is there and which buttons it provides using the plugin list at the end of that file.

7.x-2.x is our main "target" now and things are backported to 6.x-2.x after that, though in this case a single patch should be able to cleanly apply to both.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

In CKEditor 3.5 the element is named iFrame while in nightly build it is named IFrame.

Also the button/functionality IS contained in the current download 3.5. Starting one of the samples shows it.

TwoD, it seems to me there's something more needed than adding the button to the internal plugin list(s).
Can you help me fix this?

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Active » Needs review
StatusFileSize
new wysiwyg.HEAD_.ckeditor-iframe.1025296.4.patch586 bytes

Hmm, the official button name is just "iFrame", but I wonder if we should name it "Insert iFrames" or similar instead?
Hence the "needs review" rather than committing it right away...
Thoughts?

The patch is made for HEAD (7.x-2.x-dev) but should apply to any version since they are almost identical.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

You're absolutely right. It works with "Iframe".

Is there a version check needed to remove the tool on unsupported previous versions?

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new wysiwyg.HEAD_.ckeditor-iframe.1025296.6.patch947 bytes

Yes, of course.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Title: CKEditor missing iFrame button » Update CKEditor to support iFrame button
Status: Reviewed & tested by the community » Fixed

Thank you for reviewing and testing!
#6 was committed to all branches.

The -dev snapshots will be updated within 12 hours and this fix will be in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.