The CKEditor is missing the button for the internal iFrame plugin.

This is a default function that CKEditor supports.

A quick try didn't help to make Wysiwyg support this feature. Any idea what was missing?

Members fund testing for the Drupal project. Drupal Association Learn more


miro_dietiker’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev

This seems related:

While it should be part of 3.5 i still see a "MISSING" comment in the sources when grepping for iFrame.
EDIT: "MISSING" seems to refer to missing translation for the matches.

Also the release blog talks about iframes support:
And here is the full iframe documentation

TwoD’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

Thanks for creating an issue about this, I know this new iFrame plugin is part of the latest release but I have not yet had time to add support for it to
It should be a pretty small change, Wysiwyg just needs to be told the plugin is there and which buttons it provides using the plugin list at the end of that file.

7.x-2.x is our main "target" now and things are backported to 6.x-2.x after that, though in this case a single patch should be able to cleanly apply to both.

miro_dietiker’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

In CKEditor 3.5 the element is named iFrame while in nightly build it is named IFrame.

Also the button/functionality IS contained in the current download 3.5. Starting one of the samples shows it.

TwoD, it seems to me there's something more needed than adding the button to the internal plugin list(s).
Can you help me fix this?

TwoD’s picture

Status: Active » Needs review
586 bytes

Hmm, the official button name is just "iFrame", but I wonder if we should name it "Insert iFrames" or similar instead?
Hence the "needs review" rather than committing it right away...

The patch is made for HEAD (7.x-2.x-dev) but should apply to any version since they are almost identical.

miro_dietiker’s picture

Status: Needs review » Reviewed & tested by the community

You're absolutely right. It works with "Iframe".

Is there a version check needed to remove the tool on unsupported previous versions?

TwoD’s picture

Status: Reviewed & tested by the community » Needs review
947 bytes

Yes, of course.

sun’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

TwoD’s picture

Title: CKEditor missing iFrame button » Update CKEditor to support iFrame button
Status: Reviewed & tested by the community » Fixed

Thank you for reviewing and testing!
#6 was committed to all branches.

The -dev snapshots will be updated within 12 hours and this fix will be in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.