'description' => 'A serialized array of additional per-label data.',

Yuck. ;) sdboyer confirmed in IRC we don't need this anymore, and it's cruft.

Not urgent, but something we should cleanup after sprint 8.

CommentFileSizeAuthor
#8 0001-Issue-1017974-by-Jonathan-Webb-marvil07-Remove-versi.patch4.48 KBmarvil07
#3 versioncontrol_1017974.patch870 bytesjonathan webb

Comments

jonathan webb’s picture

jonathan webb commented
Assigned: Unassigned » jonathan webb
sdboyer’s picture

sdboyer commented

I'd accept a patch for this.

jonathan webb’s picture

jonathan webb commented
Status: Active » Needs review
StatusFileSize
new versioncontrol_1017974.patch870 bytes

Here's the patch. I tried verifying with the test suite, but the results are inconclusive:

Before: 209 passes, 80 fails, and 77 exceptions
After: 209 passes, 80 fails, and 77 exceptions

sdboyer’s picture

sdboyer commented
Status: Needs review » Needs work

It's almost completely good, except that there are still a couple checks that look for the $data member in the tests (now unnecessarily/inappropriately). Clearing those out myself...

sdboyer’s picture

sdboyer commented
Issue tags: -git phase 2 +git phase 2 leftovers

Didn't have time to finish this up, and forgot to retag it.

sdboyer’s picture

sdboyer commented
Status: Needs work » Postponed
marvil07’s picture

marvil07 commented
Priority: Normal » Major
Status: Postponed » Active
Issue tags: +versioncontrol-6.x-2.0-release-blocker

IMHO the less schema changes post stable, the better

marvil07’s picture

marvil07 commented
Status: Active » Fixed
StatusFileSize
new 0001-Issue-1017974-by-Jonathan-Webb-marvil07-Remove-versi.patch4.48 KB

All tests are passing with this patch.

And AFAIK we never used data for labels in the code, so pushing this patch.

dww’s picture

dww
we/he/they
commented

Sweet, thanks marvil07!

Status: Fixed » Closed (fixed)
Issue tags: -git sprint 9, -git phase 2 leftovers, -versioncontrol-6.x-2.0-release-blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git sprint 9, +git phase 2 leftovers, +versioncontrol-6.x-2.0-release-blocker

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit e431cb9 on 6.x-2.x, repository-families, drush-vc-sync-unlock by marvil07: 
    Issue #1017974 by Jonathan Webb, marvil07: Remove {versioncontrol_labels...

  • Commit e431cb9 on 6.x-2.x, repository-families by marvil07: 
    Issue #1017974 by Jonathan Webb, marvil07: Remove {versioncontrol_labels...