It seems like there was no issue for this, but sdboyer has been working on it, and committed some stuff at:

I opened this because there are two bugs there:

  • Nothing is returned on hook_views_default_views()
  • It seems like there was a missing view: vc_git_user_commits (referenced from backend, but do not exists)

So, patch attached for returning views, but waiting on feedback about vc_git_user_commits from sdboyer before removing that as default view set.

PS: @sdboyer: I think 10 commits deserve an issue ;-)

CommentFileSizeAuthor
#2 1013872-return-all-the-views-2.patch670 bytesmikey_p
0001-Finish-versioncontrol-views-sets-implementation.patch1.3 KBmarvil07

Comments

sdboyer’s picture

sdboyer commented
Title: Finish versioncontrol views sets implementation » Finish versioncontrol_git's views sets default views
Status: Active » Fixed

Ahh yup, looks like I did forget to return them all. One of those annoying things about working on default views - you have to try to manually revert them in order to notice that there's something wrong with how you've declared the defaults. That bit I've added. And instead of removing declaration for the user commit view, I've just added that view; it's an important one to the spec I set forth in #970200-15: Create shippable commit views.

mikey_p’s picture

mikey_p commented
Status: Fixed » Needs review
StatusFileSize
new 1013872-return-all-the-views-2.patch670 bytes

Forgot to add the last view to the return.

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed

Giggle. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 8

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 8

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit a841513 on 6.x-2.x, fix-invalid-default-branches, fullsync-memory by sdboyer: 
    Issue #1013872: Add the git-specific per-user commit view and make sure...
  • Commit c2eb4e9 on 6.x-2.x, fix-invalid-default-branches, fullsync-memory by sdboyer:
    Issue #1013872 by mikey_p: Need to add all the views to the array for...