co-maintained = projects where you have commit access.

-K

Comments

dww’s picture

yup. i've thought the same thing for quite a while. i'm all in favor of this.

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new1.68 KB

actually, now that i did it on a test site, i'm not sure i like this. ;) rather, i'd like there to be a way to turn it on/off (either as a separate URL, arguments in $_REQUEST, and/or a form element of some kind). i've got CVS access on a few projects that would overwhelm my usual view of my projects (like OG). it'd be nice to still provide all projects you really own vs. all projects you just co maintain/help with...

but, here's a patch for the always-show-everything approach, as a starting point. ;)

Zen’s picture

Tabs perhaps?

The patch itself (visually) appears to be fine. However, I believe that (while it is off-topic and might not matter in this case) $tablesort_sql should just be appended rather than substituted via a %s in the query in question.

-K

dww’s picture

the trouble w/ tabs is what URL to use. "/project/user/dww" works for anyone to see all projects owned by dww. ditto with a uid (e.g. /project/user/1 shows you all of Dries's projects). so, if we try to make tabs at /project/user/ we need something like "/project/user/owner" and "project/user/maintainer" which would then a) potentitally conflict with any usernames like that or b) we'd break everyone's existing bookmarks...

Zen’s picture

I see. Perhaps following the tracker module might be helpful..

Offhand,

  • /project/user/uid (or username) shows the projects page for user uid.
  • /user/uid/project shows my project page. This is linked to by "My projects".
  • The above has two tabs: maintained and co-maintained.

This has the added benefit of being displayed in the user's account pages.

Cheers,
-K

hass’s picture

Interesting, and when will we get this in? 7 months without a change is a long time...

hunmonk’s picture

Version: 4.7.x-2.x-dev » 5.x-2.x-dev
Status: Needs review » Needs work

@hass: it will get in when somebody codes it properly. are you volunteering?

what about a main table with what's there now, and a 'Projects with commit access' table in a collapsible fieldset?

nancydru’s picture

So, I guess the answer to http://drupal.org/node/199093 is no.

webchick’s picture

IMO the proper way to handle this is with subscription options. The same way you can "subscribe" to individual issues (by posting a reply), which show up under "My issues", you should be able to "subscribe" to individual projects, which show up under "My projects." This way you can follow projects' issues whether you are a co-maintainer or not, and maintainers could ignore projects they no longer care about or whatever. ;)

Any project you are a maintainer or co-maintainer of would have a subscription flag for it automatically, but you could also unsubscribe through a theoretical robust subscriptions interface. ;) I imagine there's an issue for this already.

nancydru’s picture

Angie, I'm not sure that would work for me; I'm already subscribed to several projects, most of which I am not a maintainer for and wouldn't want on my "My projects" list.

dww’s picture

Status: Needs work » Postponed

Right. This should all be handled via subscriptions and views. This is a fine issue to discuss this particular feature in.

webchick’s picture

Status: Postponed » Needs work

Right. That's why you would have the ability to unsubscribe from projects you don't want, same as you would issues under this hypothetical feature. See http://drupal.org/node/34496.

webchick’s picture

Status: Needs work » Postponed

Sorry! Didn't mean to change status.

webchick’s picture

Btw, you don't even need something as fancy as Subscriptions module for this. Views Bookmark is a module which would be more aptly named "Arbitrary Node Flags." You simply add a "Subscribe" bookmark to projects and issues, and have your "My projects" View display nodes that have that flag on, with an RSS argument to show the feed icon at the bottom. Same for "My issues". Simple. I click the link to add it to my list, I click the link to remove it from my list. And no more responding "subscribe" to issues anymore. ;)

Would of course need review by security team, etc. etc.

nancydru’s picture

I want to remain subscribed to the other modules so I get email about those issues that I might be able to help with, such as I promised Derek. But they are not projects for which I am responsible - those are the ones I want in the "My Projects" list. So maybe the bookmarks solution is better - I could flag some as "My Projects" and others as "Following."

oadaeh’s picture

According to http://drupal.org/node/27367 (and if it is current), neither Subscriptions nor Views Bookmark are used on d.o. If I remember correctly, it will be quite a task getting either on them in use here. Am I correct on that? Regardless of how difficult it may or may not be, is there a documented process of the steps necessary to get a module on d.o?

Also, according to the project nodes, Views Bookmark is being replaced by Flag (http://drupal.org/project/flag), which might be more of what webchick was talking about.

I would also like to see this functionality, and I am willing to help out in whatever capacity I can.

aclight’s picture

Assigned: dww » Unassigned

#289124: show co-maintained modules in "My projects" has been marked as a duplicate of this issue. I'm also unassigning dww since I think he would have finished this by now if he were really working on it :)

joachim’s picture

+1
Skim-reading the comments it looks like we're making this a lot more complicated than it needs be...

dave reid’s picture

+1 for this. It really seems like integration with the Flag module would be best.

nicholas.alipaz’s picture

Version: 5.x-2.x-dev » 6.x-1.x-dev

Any further developments on this idea now that d.o. is running the 6.x version of project issue tracking?

pasqualle’s picture

after #69556: move "cvs access" tab into project, make it generic this issue gets more complicated, like: 'My projects' should also display projects where I have some maintainer rights.
Could be the status changed to active, or is it still postponed on something?

dww’s picture

Priority: Minor » Normal
Status: Postponed » Active

Sure, we can make it active. I think how it needs to work is separate tabs under "My projects" for:

- Projects you own (current behavior, default tab)
- Project you're any kind of maintainer on (using the new project maintainer data)

In the future, we can add:
- Projects you subscribed to (based on flag, still blocked/postponed on #34496: [meta] Add Flag module to allow users to subscribe/unsubscribe without posting a comment)

In terms of the tab/URL woes I mentioned in #4, probably we should always use /project/user/[username]. So, /project/user can just redirect to /project/user/[username] which gives you the default owner tab (which is technically /project/user/[username]/owner). But, you can also click on the "Maintainer" tab to get to /project/user/[username]/maintainer. In the future, we'd add /project/user/[username]/subscribed (or something).

This is all based on views now, so it should be pretty easy to do. We'll need a trivial menu callback that lives at /project/user itself to do the redirects, but otherwise, this should almost entirely be possible via clicking it together. The however, it's possible I didn't export enough data to views over at #69556: move "cvs access" tab into project, make it generic so we might need some additional views support in project_issue.

xjm’s picture

Tracking.

pcambra’s picture

Having the projects you own and those that you co-mantain somehow in "your projects" tab would be very useful indeed, specially now that the co-mantaining permissions is more granular now.

xjm’s picture

Anything we can do to move this issue along?

dww’s picture

Re: "Anything we can do to move this issue along?"

Certainly. I spelled out the plan in #22 -- you can just do it. You can start with the http://drupal.org/project/drupalorg_testing install profile and upgrade to the latest project and project_issue code from CVS HEAD. Then you can try clicking the new views together. If you get it working, you can export the views to code, and paste them here, or better yet, create a patch that modifies the existing default view (if necessary) and adds the new views as separate files in project_issue/views/default_views. If we in fact need the menu callback I mentioned in #22, that'd be a patch for project_issue.module.

Good luck,
-Derek

pcambra’s picture

Hi dww,
I've tried to start working on this issue, but when I download the Drupalorg testing profile and install it, it seems that there is not Maintainers Tab in the project page as there is in drupal.org, so I can't give access to more than one user to a project, how can I have the maintainers tab enabled?

Thanks

dww’s picture

... and upgrade to the latest project and project_issue code from CVS HEAD

pcambra’s picture

Yeah, right, sorry about that, I have it working now.

I'm working on it

salvis’s picture

Looking forward to see this.

webchick’s picture

The consequences of co-maintained projects not showing up in your "My projects" view are now worse with sandbox projects. There is no way to guess your way back to the URL, and sandboxes aren't showing up in search results. (At least currently; dww and pwolanin are looking into it.)

silverwing’s picture

Scyther’s picture

Sub

davisben’s picture

Subscribing to keep track of this. I'm going to take a stab at it when I have some time to dedicate.

drumm’s picture

I started the buildout of a dev site called myprojects for this. Details on our setup are at http://drupal.org/node/1018084.

dww’s picture

Issue tags: +prairie

Leisa and I were discussing this the other day in the context of some Prairie Initiative stuff looking at the contributor UX on d.o. I think a staging site is a bit premature. At this point, we mainly need a design/plan. Some ideas:

- The current page is really two totally separate things: a table of your projects with some quick-links for maintainers vs. a custom query of issues from all your projects. Neither is particularly effective since one page is trying to do both.

- We should move the issue view entirely to a subtab of "Your Issues", and then redesign this "Your Projects" page to just focus on the first thing -- the table of your projects. *That* could easily be tabbed (or perhaps even multiple tables down the page) for "Projects you own" vs. "Projects you (co)maintain" vs. "Projects you follow" (or something). If the page is just trying to do this one thing, it'd be possible to include more useful links or metrics (or both) in the project table, without fear of pushing the issue view so far below the fold no one knows it's there or can use it.

- "Your issues" would then have tabs for separate views for something like:

The exact labels are still TBD, but this is the basic idea. Point being the issue view at the bottom of the current "Your Projects" page is really about issues, not projects. Hence, it should live with "Your Issues" not "Your Projects".

Anyway, before we bolt more stuff onto this page, I'd like to see a more holistic plan for how to clean up the user dashboard/profile section to make more sense...

Scyther’s picture

Sounds great!

EvanDonovan’s picture

dww's suggestion in #36 sounds amazing. Would that be difficult?

I wouldn't want this issue to get held up if it would be simpler in the interim just to make a single separate tab for the co-maintained projects.

nick_vh’s picture

Totally a good effort, any effort that happens with pages that are currently not so usable is good.
I'm currently not aware on how I can help this effort get some traction but I'd love to help

tsvenson’s picture

I'm helping out with support for a few projects and have got some _special_ role by the maintainers so that I can assign issues to any of the (co)maintainers and also update the project page.

Being able to get an overview of my roles for projects would be really useful to have on my account page.

Would of course also be nice if that information also was shown on the public profile page as well.

I would also like to suggest that the "Maintainers for [project]" block on the project pages could be renamed to "[project] team members" and then list the various roles and users for it.

dww’s picture

@tsvenson: Your proposal about the "Maintainers for [project]" block needs to go into a new issue. That's off-topic for this thread. This is just about issue listings as I described at #36.

Thanks,
-Derek

jelle_s’s picture

I'd love to see this happen on d.o! especially as described in #36

Anonymous’s picture

Status: Active » Needs work
StatusFileSize
new15.81 KB
new1.9 KB

I'd very much like to see something happen here.
I'd personally prefer a simple solution like the one proposed in #22 implemented ASAP to get this fixed, then another separate issue opened for a re-working of the projects/issues pages as per #36.

I therefore setup a Drupal.org testing site and started making changes based on dww's suggestions. They don't work properly yet, but it's a start that hopefully someone can add to...

hass’s picture

Re #43:

+++ b/project_issue.module
@@ -347,6 +345,19 @@ function project_issue_help($path, $arg) {
+  $path = 'project/user/';
+  $path .= $user->name;
+  $path .= '/owner';
$path = 'project/user/' . $user->uid . '/owner';
dww’s picture

The D6 version of d.o is basically in a feature freeze at this point. Sadly, from what I understand, the D7 port is also basically on hold for now. So I'm not sure what to tell you. But, I'd hate to see you waste energy on a D6 version of this feature that's unlikely to be deployed. So, it's *probably* safer to work on a D7 version of this (and at that point, it might as well be the full solution I described at #36) since even though it's likely to be longer before it's deployed, it's more likely to (eventually) happen. :/

*shrug*
-Derek

Anonymous’s picture

This is the sort of thing that makes me wonder about the sanity of 'feature freezes' - at least in the context of an already released project, and the ones running on Drupal.org at that.

From what I can tell after reading through Drupal core's release cycle, the benefits of a feature freeze are essentially making it possible to actually release a project (rather than continually adding more and more features). This I understand and agree with. However when it comes to a project that's already released, I don't see why certain features can't be added that fix an obvious problem...

Especially projects running on Drupal.org. We want to make using D.o simple and easy for both general users and maintainers. The fact that there's no centralised view of projects/issues that someone maintains means they're not going to see new issues pop up (without manually checking each project's issue queue) which will just lead to frustrated users.

Anyway, that's my little rant over :)
Unfortunately I don't have the knowledge, expertise or time to help implement the full solution proposed in #36, so I guess I'll just have my fingers crossed that someone else can get to it at some stage.

@hass: Good point. It must have been getting late when I did that ;)

dww’s picture

In this case "feature freeze" means something a bit different: "entering end-of-life." There are limited resources to maintain this code, and the priority is getting working D7 versions shipped Soon(tm). On d.o, again, it's a conscious decision to get a D7 version launched that's why we're saying we want to stop putting new features into the D6 site. And this is a new feature (although I agree it fixes an annoying UX problem).

Hope that clarifies. Meanwhile, feel free to work towards a D7 version of #22 if you'd prefer. I'm not trying to tell you what to do. I'm just trying to help you avoid wasting energy on code that's not going to be released or deployed, and at this point, it's unlikely that new D6 features are going to happen.

Thanks,
-Derek

Anonymous’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev

Thanks for the clarification!

I was really only suggesting working on #22 as that would have provided a quick solution that could have been committed while work on #36 progressed. If there's no chance of getting something committed soon, then I can see the benefit of not duplicating work and ignoring #22 in favour of #36.

Changing version to 7.x-2.x-dev.

liam morland’s picture

mac_weber’s picture

It would be cool if someone who has been following all this discussion could update the issue summary writing what is the current status of the patches and what work is still needed to make it happen.

tsvenson’s picture

I would say the probability of the patch in #43 to work is quite slim. The project and project_issue modules have been rewritten from scratch. See https://association.drupal.org/node/17983 for more info about that.

mgifford’s picture

Issue summary: View changes

What's the status of this after the D7 upgrade?

nick_vh’s picture

Yes, would be good to get this in.

mgifford’s picture

Issue tags: +maintain

I took a quick look at this earlier today. The changes to the project.module patch seem pretty easy to bring across to:
/sites/all/modules/drupalorg/drupalorg_project/drupalorg_project.module

However, project_issue-101341-43.patch is going to take a lot more work to upgrade as it's almost all changed.
/sites/all/modules/project_issue/project_issue.module
/sites/all/modules/project_issue/views/default_views/project_issue_user_projects.view.php
/sites/all/modules/project_issue/views/default_views/project_issue_user_projects.view.php

liam morland’s picture

damienmckenna’s picture

It'd be cool if the table could list all projects you have any access to and have columns indicating each specific permission.

oadaeh’s picture

I believe there is a duplicate issue of this one, where some work is happening, here: #2358375: My Projects view should show co-maintained projects

hass’s picture

Status: Needs work » Closed (duplicate)
Parent issue: » #2358375: My Projects view should show co-maintained projects
tim.plunkett’s picture

Status: Closed (duplicate) » Active

This issue has been open for 8 years. Please close the other one.

dww’s picture

tvn’s picture

Issue tags: -DSWG Comm Tools Team Priority, -prairie, -maintain
yesct’s picture

Issue tags: +maintain, +drupal.org contribution crediting

some contribution credit issues have d.o profile improvements tag, and some have nothing and are easy to get lost (and not about profiles), so tagging to organize credit ones.

tvn’s picture

Issue tags: -maintain
realityloop’s picture

Assigned: Unassigned » realityloop

I'm working on fixing this now..

realityloop’s picture

Status: Active » Closed (duplicate)

Patch added at https://www.drupal.org/node/2358375#comment-10373737 which had some more recent info

realityloop’s picture

Status: Closed (duplicate) » Needs review
StatusFileSize
new3.05 KB

Patch with Index added as @drumm suggested at #2358375: My Projects view should show co-maintained projects, image of explain before and after included, suggest breaking listing of co-maintained modules in exposed filter into it's own issue

Before

After

Moved back to here from #2358375: My Projects view should show co-maintained projects

  • drumm committed e5fffc1 on 7.x-2.x authored by realityloop
    Issue #101341 by realityloop: 'My projects' should also display projects...
drumm’s picture

Status: Needs review » Fixed
Issue tags: +needs drupal.org deployment

Looks good, committed.

drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed to Drupal.org.

attiks’s picture

Thanks all, is it normal I see 'Drupal Core' as well?

drumm’s picture

A bunch of people, including you, have "maintain issues" access to Drupal Core, which is technically maintainership.

attiks’s picture

#71 That makes sense, thanks for the feedback

webchick’s picture

Nice one!

damienmckenna’s picture

A huge +1 for this, thank you everyone for collaborating on this very useful improvement!

mitchell’s picture

> "maintain issues" access to [a project] is technically maintainership.

Perhaps profile pages' `Projects` section could also reflect this. In keeping with the involvement measure, per-project, we could possibly extend `(# commits)` to `(# commits & # issues)`, summed and reverse sorted.

.Edited for context and clarity.

hass’s picture

I would love to see a follow up where I can disable some project myself...

berdir’s picture

This is great!

Unfortunately, the exposed filter in the view doesn't reflect this yet, it still only shows projects that I created. Which means that I can't filter on those projects. For example, I'd like to filter on all projects except Drupal core, since the view isn't that helpful for anyone who has some maintainer access for Drupal Core.

drumm’s picture

We mentioned splitting that out into another issue, but I don't think one got made until now. Here it is #2579293: 'My projects' view should include all co-maintained projects in project exposed filter.

nancydru’s picture

My list includes modules that, as far as I know, I am not a maintainer of, nor have I ever even submitted a patch.

michelle’s picture

I thought the same, Nancy, as there were some on there I'd never even _heard_ of. But then I went and looked at the maintainers and I was on there. No clue why or how.

hass’s picture

Issue summary: View changes
Status: Fixed » Needs work
StatusFileSize
new39.29 KB

There is a major bug. The form field "Project" on project/user does not list the projects I co-maintain. This disallow filtering.

tim.plunkett’s picture

Status: Needs work » Fixed

@hass, did you read *any* of the comments? #77 and #78 discuss this.

hass’s picture

Damn, I subscribed to this case already :-(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.