For translation texts, we should use the new context system to be able to know the difference from identical words. In commerce short texts with order is often mistranslated as order can both be a commerce order and the order of an ordered list of items.

I don't know if there are more of cases but this one has been bugging me a bit for some time now.

Comments

googletorp’s picture

googletorp commented
Status: Active » Needs review

I created a patch for this at github.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Great, I pulled this one and made a note in #952002: Add translation string contexts.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hansfn’s picture

hansfn commented
Title: Use context in translation where needed. » Use context in Order related translation where needed.
Status: Closed (fixed) » Needs work

I think you might have missed some "Order" strings in commerce/modules/order/includes/views/commerce_order_ui.views_default.inc. The array $translatables['commerce_orders'] contains "Orders", "Order number" which probably should have a context too. (I noticed because I had to translate "Orders" twice.)

PS! I don't 100% understand what the $translatable array does since (for example) the string "Manage orders in the store." isn't in the array, but it's still possible to translate it.

Please revert the title change if it was inappropriate.

rszrama’s picture

rszrama commented
Title: Use context in Order related translation where needed. » Use context in Views translatables where needed.
Category: bug » task
Status: Needs work » Postponed

Hmm, I'll have to think about it; those strings are coming straight from Views, and it could be a pain to end up having to maintain custom contexts in there.

hansfn’s picture

hansfn commented

I understand that it can been a pain, but there should be an easy way to translate all parts of Commerce. That is needed for the Commerce goal of world dominance ;-) I know I can edit the View itself, but doesn't sound like a great solution ...

no2e’s picture

no2e commented
Issue tags: +string context

(tag added)

jsacksick’s picture

jsacksick commented
Issue summary: View changes
Status: Postponed » Closed (outdated)