piggy-backing off of #1001668: Configurable path for the git binary - we need to make sure to tell the user very blatantly if git is not on path - i had to symlink /usr/bin/git -> /usr/local/bin/git in order got get a repo added. I would have had no way to even KNOW that these were related if i hadn't had sdboyer helping me debug.

Comments

marvil07’s picture

Assigned: Unassigned » marvil07

I tried it renaming my git binary, and yep, when you are creating a repository, you only see the drupal message "The specified path is not a valid Git bare repository."

I'm in the middle of a patch.

marvil07’s picture

Title: bitch if git isn't on path » Provide feedback when git is not on the path
Status: Active » Needs review
Issue tags: +git phase 2, +git sprint 7
StatusFileSize
new4.13 KB

Ok, here the patch, I tested it, but gonna commit it after a review ;-)

sdboyer’s picture

Status: Needs review » Reviewed & tested by the community

The patch looks mostly good, but I unfortunately had to make a partially overlapping commit at #1010878: Git bin is often echoed instead of executed b/c this was blocking my work on util. Sorry. I only did the upgrades to the git binary path checker, though, so if you could add the other improvements you made, that'd be excellent.

eliza411’s picture

Issue tags: +git sprint 8

Tagging for Git Sprint 8

marvil07’s picture

Status: Reviewed & tested by the community » Fixed

Ok, committed after making the changes needed in order to apply this cleanly.

marvil07’s picture

forgot the patch :-p

eliza411’s picture

Issue tags: -git sprint 8

Thanks, Marco. Untagging since this is fixed before Sprint 8.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 7

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit fc50c6e on 6.x-2.x, fix-invalid-default-branches, fullsync-memory by marvil07:
    feature #1009480: Provide feedback when git is not on the path.