piggy-backing off of #1001668: Configurable path for the git binary - we need to make sure to tell the user very blatantly if git is not on path - i had to symlink /usr/bin/git -> /usr/local/bin/git in order got get a repo added. I would have had no way to even KNOW that these were related if i hadn't had sdboyer helping me debug.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 0001-feature-1009480-Provide-feedback-when-git-is-not-on-v2.patch | 4.43 KB | marvil07 |
| #2 | 0001-feature-1009480-Provide-feedback-when-git-is-not-on-.patch | 4.13 KB | marvil07 |
Comments
Comment #1
marvil07 commentedI tried it renaming my git binary, and yep, when you are creating a repository, you only see the drupal message "The specified path is not a valid Git bare repository."
I'm in the middle of a patch.
Comment #2
marvil07 commentedOk, here the patch, I tested it, but gonna commit it after a review ;-)
Comment #3
sdboyer commentedThe patch looks mostly good, but I unfortunately had to make a partially overlapping commit at #1010878: Git bin is often echoed instead of executed b/c this was blocking my work on util. Sorry. I only did the upgrades to the git binary path checker, though, so if you could add the other improvements you made, that'd be excellent.
Comment #4
eliza411 commentedTagging for Git Sprint 8
Comment #5
marvil07 commentedOk, committed after making the changes needed in order to apply this cleanly.
Comment #6
marvil07 commentedforgot the patch :-p
Comment #7
eliza411 commentedThanks, Marco. Untagging since this is fixed before Sprint 8.