FIx views_handler_filter_string

So, do we kill the "case sensitive" option completely?
We already say "MySQL might ignore case sensitivity.", so if now postgres is the same I'm not sure there's much we can or should do.

Also,

+  function variable_name() {
+    return ':' . __CLASS__ . __FUNCTION__ . $this->options['id'];
+  }

Bluurgh. Took me a few seconds to realize that this is actually generating a placeholder. Should it then find a home in views_plugin_query_default?
Since we had the same placeholder problem in arguments, would be good to solve it across the board.

The placeholder trick is really neat. We just need to move it to views_plugin_query_default, rename it, give it some docs, and make sure it works in all situations (will it work for those arguments in subqueries? We have some complicated queries...)

I'll reroll the patch for case sensitivity.

Sadly this nice trick with __FUNCTION__ and __CLASS___ don't work in query_default, but it's okay.

Yeah, I overlooked that little fact.

Leaving the topic alone for now then, and just providing a reroll.

Btw, shouldn't op_contains() get the same db_like() treatment?

I'll take another peek at this issue when I come home tonight, my brain is refusing to boot up at the moment.

Better patch (last one left one instance of 'case').
Note that we need to fix views_handler_argument_string the same way.

Awesome.

Was wondering whether we should add a counter to the unique_placeholder() function, so that we can use it multiple times from the same function (which will surely be needed).
In general, I'm having mixed feelings about unique_placeholder in views_handler. On one side, it makes debugging easier, since I can easily see where the placeholder is coming from. On the other hand, it's a dbtng specific function in a handler, code that should generally be in the specific query plugin.

   var $placeholder_counter = 0;
 
+  /**
+   * Provides the current used placeholder base.
+   */
+  var $placeholder_base = 'default';

Kill both, they are unused

http://drupal.org/cvs?commit=470112

A follow-up will be to convert all code to use the new placeholder method.
Best done after add_where_expression() lands (or simultaneously, since it touches the same code)