PostgreSQL not working in CREATE TABLE node_<field> code [#100546]

Comment	File	Size	Author
#9	cck_19.patch	4.63 KB	KarenS
	d5_content_admin_pgsql_20061130_1513_patch.txt	2.45 KB	sammys

Comment #1

yched CreditAttribution: yched commented 30 November 2006 at 20:01

Thanks. I don't know a thing to PostgreSQL, and I have no config to test.
Is this a bug fix or 'just' an improvement ?
Plus : can you provide the update function as well ? :-)

Log in or register to post comments

Comment #2

yched CreditAttribution: yched commented 30 November 2006 at 20:07

Is this a bug fix or 'just' an improvement ?
Sorry, the title says 'not working' so I guess I have the answer...

Update function still accepted, though :-)

Log in or register to post comments

Comment #3

yched CreditAttribution: yched commented 30 November 2006 at 20:17

I'm not sure we need an update function actually :
If cck is currently broken for prostgre, maybe there are no tables to update...
Plus cck 5 is beta.

Karen, dopry, what do you think ?

Log in or register to post comments

Comment #4

KarenS CreditAttribution: KarenS commented 4 December 2006 at 19:46

This seems to be in line with core, but needs to be expanded. The content.install file has some changes that need to be made and there is another place in the content_db_add_column function that needs a change -- the place where the mappings are done. Currently the mapping script is going to create 'integer unsigned' instead of 'int_unsigned', so some thought needs to go into how that script should be changed to produce the right results. There may be other places that need patching, those were two I saw.

Log in or register to post comments

Comment #5

KarenS CreditAttribution: KarenS commented 4 December 2006 at 19:47

Status:

Needs review

» Needs work

Changing status...

Log in or register to post comments

Comment #6

KarenS CreditAttribution: KarenS commented 4 January 2007 at 20:27

Bumping this issue. This is needs more work and needs to get finished up.

Log in or register to post comments

Comment #7

Pieter Janssens CreditAttribution: Pieter Janssens commented 4 January 2007 at 21:51

the current patch seems to fix the issue for module content_admin.inc. the module content_crud.inc needs the same corrections.
also see the issue http://drupal.org/node/106892 i opened for this postgres problem.

Log in or register to post comments

Comment #8

KarenS CreditAttribution: KarenS commented 17 January 2007 at 16:14

I'm marking http://drupal.org/node/109060 and http://drupal.org/node/106892 as duplicates of this issue. We'll consolidate work on a patch to fix this in this issue.

Log in or register to post comments

Comment #9

KarenS CreditAttribution: KarenS commented 17 January 2007 at 16:31

File	Size
cck_19.patch	4.63 KB

Here's my proposed patch against HEAD for this problem. I need to know if it is correct and fixes the problem, if it fixes all the places that need to be fixed, and confirm that it does not break version 7 compatibility or whatever our standard is.

The patch fixes content.install, content_crud.inc, and content_admin.inc, including the $mappings.

Log in or register to post comments

Comment #10

KarenS CreditAttribution: KarenS commented 17 January 2007 at 16:43

Status:

Needs work

» Needs review

Need to change the status...

Log in or register to post comments

Comment #11

KarenS CreditAttribution: KarenS commented 17 January 2007 at 17:13

Assigned:

sammys

» KarenS

Guess I should also change who's assigned to this.

Log in or register to post comments

Comment #12

KarenS CreditAttribution: KarenS commented 25 January 2007 at 19:21

Status:

Needs review

» Fixed

I never got any confirming reviews for this patch, but it's consistant with the way core is handling it so I assume it is OK and I just committed it to HEAD and 5.x. It looks like there is nothing to change in 4.7 since 4.7 doesn't use 'integer unsigned' for postgres anywhere.