Hello.

It is very usefull to have hooks on linkedin account saves/deletes.
Please review patch.

Comments

greg.harvey’s picture

Seems good to me. I'd +1 this.

bellesmanieres’s picture

Assigned: Unassigned » bellesmanieres
StatusFileSize
new1.69 KB

Good idea, might be useful. Made a few changes to the original patch though :
- renamed to "linkedin_account_inserted" and "linkedin_account_deleted" (I'm always afraid of name collision with functions ending in "delete/save" + it occurs after the save/delete operation has been made, so sounds more logical)
- "linkedin_account_inserted" called only at access token save time : request token is only a temporary token, that is called before users have authorized our instance to access their data, so it's useless at that time.
- Not sure i see the point of passing "$oauth['oauth_token']" and "$oauth['oauth_token_secret']" to linkedin_account_inserted. Think $account is sufficient (tokens are in db, should they ever be needed anyway), but I might be missing something here ?

Can you try the attached patch before I commit ?

bellesmanieres’s picture

Status: Needs review » Fixed

This has been fixed quite a long ago, had forgot to close the issue !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Assigned: bellesmanieres » Unassigned
Status: Closed (fixed) » Active

It would be nice to have these hooks in the D7 version aswell.

Grts

TimLeytens