Started at #997254: [meta] Create tests that exercise CRUD & methods on all our entities.

There is some initial stuff on each entity testRead() provided at #1000862: Basic CRUD tests for entities.

This is focused on:

- Any $options that can be set for any kind of CRUD operation - so loading with the controllers or saving/deleting with the entities themselves - must be tested and verified to work as intended.
- We need to test $conditions on controllers. Not every possible condition, though; only each unique condition-handling logic path. Per controller. So we need just one check for all straight field filters (i.e., $query->condition($alias . $field_name, $value)), and then additional checks for any sort of condition that follows an alternate path.
- Tests should aggressively search for cache inconsistencies/misses, as the immaturity of VersioncontrolEntity::cacheGet generally makes me think we could see a fair number of those, and that's potentially really bad.

CommentFileSizeAuthor
#1 0001-Repository-controller-tests.patch3.97 KBmarvil07
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marvil07’s picture

Assigned: Unassigned » marvil07
Status: Postponed » Needs work
FileSize
3.97 KB

Tests for VersioncontrolRepositoryController:

- There are not specific options available to test
- Test each condition.
- Try to test cache.

BTW I discover and tried to solve #1001480: Prevent empty values to be attached to the controller query, tests FTW

eliza411’s picture

Issue tags: +git sprint 7

Tagging for Git Sprint 7.

webchick’s picture

Assigned: marvil07 » Unassigned
Issue tags: +git low hanging fruit

This isn't git low hanging fruit, per se, but it's one of those tasks that people who are NOT sam and marco could conceivably work on, and is super important to the viability of the project.

Unassigning Marco.

sdboyer’s picture

Yeah, later. We can launch without these.

marvil07’s picture

Priority: Normal » Major
Issue tags: +versioncontrol-6.x-2.0-release-blocker
Josh The Geek’s picture

Issue tags: -git sprint 6, -git sprint 7

sprint tags are no longer needed

marvil07’s picture

Issue tags: +git sprint 6, +git sprint 7

Sprint tags are there for historical reasons ;-)

sdboyer’s picture

Status: Needs work » Postponed
marvil07’s picture

Not a blocker as agreed.

  • marvil07 committed 12dec19 on 7.x-1.x
    Issue #1000876: Changes VersioncontrolControllerCachingTest to use the...

  • marvil07 committed a8f5d99 on 7.x-1.x
    Issue #1000876, #2897078: Adds a test to check special operation...