Started at #997254: [meta] Create tests that exercise CRUD & methods on all our entities.
There is some initial stuff on each entity testRead()
provided at #1000862: Basic CRUD tests for entities.
This is focused on:
- Any $options that can be set for any kind of CRUD operation - so loading with the controllers or saving/deleting with the entities themselves - must be tested and verified to work as intended.
- We need to test $conditions on controllers. Not every possible condition, though; only each unique condition-handling logic path. Per controller. So we need just one check for all straight field filters (i.e., $query->condition($alias . $field_name, $value)), and then additional checks for any sort of condition that follows an alternate path.
- Tests should aggressively search for cache inconsistencies/misses, as the immaturity of VersioncontrolEntity::cacheGet generally makes me think we could see a fair number of those, and that's potentially really bad.
Comment | File | Size | Author |
---|---|---|---|
#1 | 0001-Repository-controller-tests.patch | 3.97 KB | marvil07 |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedTests for VersioncontrolRepositoryController:
- There are not specific options available to test
- Test each condition.
- Try to test cache.
BTW I discover and tried to solve #1001480: Prevent empty values to be attached to the controller query, tests FTW
Comment #2
eliza411 CreditAttribution: eliza411 commentedTagging for Git Sprint 7.
Comment #3
webchickThis isn't git low hanging fruit, per se, but it's one of those tasks that people who are NOT sam and marco could conceivably work on, and is super important to the viability of the project.
Unassigning Marco.
Comment #4
sdboyer CreditAttribution: sdboyer commentedYeah, later. We can launch without these.
Comment #5
marvil07 CreditAttribution: marvil07 commentedComment #6
Josh The Geek CreditAttribution: Josh The Geek commentedsprint tags are no longer needed
Comment #7
marvil07 CreditAttribution: marvil07 commentedSprint tags are there for historical reasons ;-)
Comment #8
sdboyer CreditAttribution: sdboyer commentedComment #9
marvil07 CreditAttribution: marvil07 commentedNot a blocker as agreed.