Provide quantity/tags in the pager settings.

+      '#title' => t('Number of pages(query)'),

How about "Maximum number of pages"

+    $form['quantity'] = array(
+      '#type' => 'textfield',
+      '#title' => t('Number of shown pages'),
+      '#description' => t('The total number of pages which are displayed. Leave empty to show all pages.'),
+      '#default_value' => $this->options['quantity'],
+    );
+

I think, hm. "Number of pager links visible" and "Specify the maximum number of links to pages to display in the pager."

Hey while we're at it, are the 'next' and 'prev' text configurable too? If they are we should make those options as well.

Ok, let's fix the bug and provide the option separately. The bug is more important.

+    dsm($pager_theme);
+    dsm($tags);

Can I get one without these? :)

I were just looking for this option and I couldn't find it. The patch applies fine and seems to work, however the default tags look like this:

    $options['tags'] = array(
      'contains' => array(
        'first' => array('default' => '« first', 'translatable' => TRUE),
        'previous' => array('default' => '‹ previous', 'translatable' => TRUE),
        'next' => array('default' => 'next ›', 'translatable' => TRUE),
        'last' => array('default' => 'last »', 'translatable' => TRUE),
      ),
    );

Re the patch in #8:

1.

+++ plugins/views_plugin_pager_full.inc
@@ -67,6 +76,13 @@ class views_plugin_pager_full extends views_plugin_pager {
+    $form['quantity'] = array(
+      '#type' => 'textfield',
+      '#title' => t('"Number of pager links visible'),
+      '#description' => t('Specify the maximum number of links to pages to display in the pager."'),
+      '#default_value' => $this->options['quantity'],
+    );

There are extra double quotes in the title and description.

2.

+++ plugins/views_plugin_pager_full.inc
@@ -145,6 +161,40 @@ class views_plugin_pager_full extends views_plugin_pager {
+    $form['tags'] = array (
+      '#type' => 'fieldset',
+      '#collapsible' => FALSE,
+      '#collapsed' => FALSE,
+      '#tree' => TRUE,
+      '#title' => t('Tags'),
+      '#input' => TRUE,
+      '#description' => t('TODO: Description'),
+    );
+    $form['tags']['first'] = array(
+      '#type' => 'textfield',
+      '#title' => t('Text for "first"-link'),
+      '#description' => t('Text for "first"-link'),
+      '#default_value' => $this->options['tags']['first'],
+    );
+    $form['tags']['previous'] = array(
+      '#type' => 'textfield',
+      '#title' => t('Text for "previous"-link'),
+      '#description' => t('Text for "previous"-link'),
+      '#default_value' => $this->options['tags']['previous'],
+    );
+    $form['tags']['next'] = array(
+      '#type' => 'textfield',
+      '#title' => t('Text for "next"-link'),
+      '#description' => t('Text for "next"-link'),
+      '#default_value' => $this->options['tags']['next'],
+    );
+    $form['tags']['last'] = array(
+      '#type' => 'textfield',
+      '#title' => t('Text for "last"-link'),
+      '#description' => t('Text for "last"-link'),
+      '#default_value' => $this->options['tags']['last'],
+    );

* Lots of TODOs and descriptions that duplicate titles.
* "Text for "first"-link" etc. - Why the dash between "first" and link instead of a space? Looks a bit messy.

3.

+++ plugins/views_plugin_pager_full.inc
@@ -200,7 +250,13 @@ class views_plugin_pager_full extends views_plugin_pager {
diff --git plugins/views_plugin_query_default.inc plugins/views_plugin_query_default.inc
index ee1877a..6b51d48 100644
--- plugins/views_plugin_query_default.inc
+++ plugins/views_plugin_query_default.inc
@@ -9,7 +9,7 @@
 /**
  * Object used to create a SELECT query.
  */
-class views_plugin_query_default extends views_plugin_query{
+class views_plugin_query_default extends views_plugin_query {
 
   /**
    * A list of tables in the order they should be added, keyed by alias.

This part is irrelevant.

Also, for those who want a D7 version here it is (with points 1 & 3 from above fixed).

Powered by Dreditor.

+1, will try to test the patch soon.

:-( I hate when I write a patch and then I think to look this up after I write it.

Anyways this looks good to me. I'm going to try and apply see what happens.

Switching to needs review to see if it still applies against the latest.

Fixing the test and uploading patch in a sec.

And now here's the patch.

I fixed some of the formatting and also changed the text around because it had some todos. I based my text arounds Drupal cores wording for theme_pager.

Also the test should be fixed with this patch.

Here's the same exact patch but without the simple-test verbose I put in there for debugging.

Either way both patches should pass :)

Ok last one I promise. This fixed a small mistake I had on the simple test.

+++ b/plugins/views_plugin_pager_full.incundefined
@@ -24,6 +24,7 @@ class views_plugin_pager_full extends views_plugin_pager {
+    $options['quantity'] = array('default' => 9);

What's with 9? This could use a comment.

+++ b/plugins/views_plugin_pager_full.incundefined
@@ -212,8 +266,18 @@ class views_plugin_pager_full extends views_plugin_pager {
+      0 => $this->options['tags']['first'],
+      1 => $this->options['tags']['previous'],
+      3 => $this->options['tags']['next'],
+      4 => $this->options['tags']['last'],

Where is index 2?

What's with 9? This could use a comment

This is the default that's used now. This default is from the default 'quantity' variable for theme_pager in core.

Where is index 2?

Missed it good catch.

In that case, why hardcore the indices at all? Just leaving them out will accomplish the same thing.

Hmm I guess that's where I got the 3 from. These seems like a bug in core regarding theme_pager.

Ok so this one has comments for the default the and weird theme_pager tags keys.

@tim.plunkett I didn't leave the default as blank because we're not checking what we pass to theme_pager, we're always passing it. So if we make our default nothing it would overwrite the standard 9 items per pager list.

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue