Not a big problem (at all), but you might want to consider improving on the UI for the settings page. The radios AFTER the submit button is a bit strange :-). The UX will be much nicer.

CommentFileSizeAuthor
#5 rearrange_child_pages.module.patch826 byteswadmiraal
book-settings.jpg13.75 KBwadmiraal

Comments

nirbhasa’s picture

nirbhasa commented
Status: Active » Closed (fixed)

I added a weight to keep it above the buttons. Its a bit tricky - adding weight = 0 causes it to go above the other items (where it is now), weight 1 puts it back down below the buttons, but its definitely better than it was.

wadmiraal’s picture

wadmiraal commented

It's not very clean, but you could change the weight of the other elements :-). You have access to the form, so you can change it dynamically. Say, give the submit button a weight of 10.

nirbhasa’s picture

nirbhasa commented

Sure I could. Im quite busy over the next few weeks, but id be happy to look at a patch if you wanted to contribute one :)

nirbhasa’s picture

nirbhasa commented
Status: Closed (fixed) » Active

Setting issue back to active

wadmiraal’s picture

wadmiraal commented
Version: 6.x-1.0-rc1 » 6.x-1.0-rc3
Assigned: Unassigned » wadmiraal
Status: Active » Needs review
StatusFileSize
new rearrange_child_pages.module.patch826 bytes

I also changed the '#value' to '#title', which is what you meant I guess.