I see that the form is creating a lot of empty space by using "visibility: hidden" instead of "display: none". Is this an attempt to fool the spambots? It wasn't an issue before with version 1.3 (what I had installed before). I've checked Firebug with the page and my theme does not appear to be causing any conflicts.

CommentFileSizeAuthor
#4 spamicide-1.8-fix.patch21.17 KBlirazsiri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

meustrus’s picture

Also, was a permission removed for viewing the "Add spamicide to this form" link? I was using that to disable it in my admin (not user/1) account because the links are getting in the way.

lirazsiri’s picture

I'd like to confirm this is an issue.

meustrus’s picture

Yes, it is an issue and still exists. I can't add Spamicide to forms in small places because the empty space is larger than the form itself (such as the Search form, to avoid DoS or just to get rid of the 'add spamicide to this form' link).

lirazsiri’s picture

FileSize
21.17 KB

Try this patch.

meustrus’s picture

Yes, that worked. Thank you. There was a lot extra in that patch that I didn't apply, though, including:

  • Removed t() function from Watchdog (which changed the function call, and I'm not sure whether it was right before or after)
  • if ($spamicide->enabled) {
  • Created new file spamicide.module.orig

The parts I did apply, though, I think are a fair improvement over the methods that I saw being replaced. Is this being committed?

lipcpro’s picture

Status: Active » Fixed

Thanks lirazsiri for the patch it solved the problem of adding a class instead of using an id. I've been really frustrated by CVS, so now that d.o. is using Git I can be more responsive to my issue queue.

Thanks for your patience all

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.