Reviewing the D7 core code and noticed that all of the three system actions (e-mail, message, and redirect) support tokens, the only difference being the e-mail action doesn't support tokens for the subject. We should just remove the token_actions.module for Drupal 7, and support any fixes for core action token replacements in token.module itself.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
9.02 KB

Actually I discover that tokens are supported for the subject field automatically by sytem_mail() in D7. So, we just add our token tree UI and remove that dang token_actions.module!

Status: Needs review » Needs work

The last submitted patch, 974946-token-remove-actions-D7.patch, failed testing.

Dave Reid’s picture

Dave Reid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 974946-token-remove-actions-D7.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Needs review
FileSize
10.65 KB

Status: Needs review » Needs work

The last submitted patch, 974946-token-remove-actions-D7.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Fixed

I give up. I pinged boomatower about test bot still trying to code review a non-existent module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.