Missing join: 'taxonomy_term_data' creating a Glossary view based on taxonomy

I made some progress on this patch:

The glossary is not working perfect in d7.

    if (!empty($this->definition['many to one'])) {
      if (!empty($this->options['glossary'])) {
        $this->helper->formula = TRUE;
      }
      $this->value = array($argument);
      $this->helper->ensure_my_table();
      $this->helper->add_filter();
      return;
    }

This part of argument_string::query is the problem. It adds a multi to one filter.
So let's see what add_filter does.

  function add_filter() {
    if (empty($this->handler->value)) {
      return;
    }
    $this->handler->ensure_my_table();

    // Shorten some variables:
    $field = $this->get_field();
    $options = $this->handler->options;
    $operator = $this->handler->operator;
    if (empty($options['group'])) {
      $options['group'] = 0;
    }

    if ($operator == 'not') {
      $this->handler->query->add_where($options['group'], $field, NULL, 'IS NULL');
    }
    elseif ($operator == 'or' && empty($options['reduce_duplicates'])) {
      if (count($this->handler->value) > 1) {
        $this->handler->query->add_where($options['group'], $field, $this->handler->value, 'IN');
      }
      else {
        $this->handler->query->add_where($options['group'], $field, $this->handler->value);
      }
    }
    else {
      $field = $this->handler->real_field;
      $clause = $operator == 'or' ? db_or() : db_and();
      foreach ($this->handler->table_aliases as $value => $alias) {
        $clause->condition("$alias.$field", $this->handler->value);
      }

      // implode on either AND or OR.
      $this->handler->query->add_where($options['group'], $clause);
    }

The problem is that add_where currently just allows to have formulars or placeholders, because dbtng has where and condition, and just condition has placeholders, but where is needed for SUBSTRING(foo)

subscribe

subscribe

Add some updated code.

Some updates

setting status

Mh

Wow here is a working patch

Merged out the vpr/views_debug stuff :)

Review doesn't offered something new.

Commited to the 7.x branch.

This causes a PHP notice with some coditions. if $operator == 'and' then $value is not defined ever. It should likely default to $this->handler->value.

Thanks! Commited to the 7.x branch.

Hrm, this ended up causing more problems with another view. Leaving open until I can find what's wrong.

Does this patch fix the issue?

It works for me.

I also had a problem using a view with $operator == 'and', and this patch fixed it for me too.

Wow. Two patch reviews!

Commited to the 7.x branch.f

Coming from #271833: Taxonomy depth for filters and exposed filters, looking forward to a stable release of 6.x-3.x with a backport of a "Taxonomy: Term ID (with depth)" filter for views based on taxonomy ;)