Hi,

I installed today's HEAD of Drupal 7, along with the permissions_select module. I'm logged in as user 1 and I have Javascript enabled.

When going to admin/people/permissions/list, I was expecting to see something resembling the image on the module front page, but the permissions page is unchanged.

I tried HEAD, the 7.x-1.x-dev branch, and 7.x-1.1, but I'm getting no result.

Thanks!

Albert.

Comments

realityloop’s picture

Ditto, confirming this release currently does nothing in D7

alberto56’s picture

Priority: Normal » Critical

Then this is critical, right?

OnkelTem’s picture

7.x-1.1 is very outdated - it's released more then year ago :)
Forget about it )

UPD. I'm gonna try this snapshot http://ftp.drupal.org/files/projects/permission_select-7.x-1.1.tar.gz now

Doesn't work either. Dev doesn't work too.. Looks like the module abandoned.

himerus’s picture

Assigned: Unassigned » himerus

I will try to get this working this weekend... not abandoned, but not high on the priority list either.

This WAS created early for D7, and yes, a good deal of things changed that make the 7.x version currently broken. I always accept patches as well, but no one has taken the effort to fix the sections in the .module and .js that would fix the issue...

I'll try to set aside an hour to get it working again this weekend.

mgifford’s picture

Thanks! We're looking forward to using it.

AndrewJarvis’s picture

Anxiously awaiting this as well! Are there any other similar modules out there? Or one that are different but solve the same problem of having to click all those checkboxes?

OnkelTem’s picture

Doesn't work. -dev just adds checkboxes in perm groups - no global controls

Vote_Sizing_Steve’s picture

The checkboxes in perm groups are added, but don't do anything for me when clicked.

kmajzlik’s picture

subscribing, there is no Drupal 7 solution for permissions UI.

Vote_Sizing_Steve’s picture

StatusFileSize
new9.94 KB
new1.59 KB

I asked my developer to fix the D7 version, and he's provided the following files (I've attached the patches, and the build), which are working for me.

I'm not sure about the global select/unselect; but think that they are going to have to be part of a future D7 version.

kmajzlik’s picture

Status: Active » Needs review

#10 seems to be working well for me with Drupal 7.8 (+ together http://drupal.org/project/filter_perms )

badsit’s picture

StatusFileSize
new7.15 KB

#10 #11 This patch as one file.

kingfisher64’s picture

I really wanted this module to add a global select all, deselect all for specific roles. It's doing my head in having to manually scroll through all the modules installed checking to see. I've never understood why the default permissions for the administrator is not to have all permissions selected. Seems very odd to have someone looking after the system who can't fully look after the system!

Is there a timeline for a version with a global select all/deselect all button?

Many thanks

kmajzlik’s picture

kingfisher: i think that administrators permissions should be set rather by http://drupal.org/project/adminrole (for Drupal 6) which is now in core for Drupal7.

badsit’s picture

StatusFileSize
new8.08 KB

The patch includes a patch from the comment #13, and I also added possibility for a global select all, deselect all for specific roles.

kingfisher64’s picture

I couldn't get this patch in post #15 to apply properly.

Is there any chance of an updated version of this module? It's so close to being completed and only needs a few additions.

steveoliver’s picture

Got this patch to apply cleanly but didn't fix anything...

steveoliver’s picture

...Sorry - it did! Works well. Thanks.

ezeedub’s picture

Priority: Critical » Normal
StatusFileSize
new7.74 KB

Here's the fix you asked for himerus. (There's whitespace stuff in here as well. Not sure if that's a plus or a minus. Just let me know and I'll re-roll it.)

Btw, I actually got here looking for the select-all perms for the admin role (not just by module) to replace what seems to be missing in core despite what it says on the adminrole module page.

It would be a separate issue, but is there any interest in overloading this module to handle that?

lefnire’s picture

Status: Needs review » Reviewed & tested by the community

Works for me

kingfisher64’s picture

Can we have all the patches rolled into a new version? Given the fact there's patches and versions on #10, #12, #15, #19. I'm hoping that the following error will disappear with a new version.

Error message
Notice: Undefined variable: rows in permission_select_theme_user_admin_perm() (line 72 of C:\wamp\www\kingfisher\sites\all\modules\permission_select\permission_select.module).

or

can someone who has all these patches applied upload the new .zip version?

defconjuan’s picture

+1 for consolidated patch

Anthony Pero’s picture

Hmmm... I downloaded the latest dev (Feb 2012), and didn't work. Applied the patch at 19. No change. No check boxes, nothing. I've cleared the cache. What am I doing wrong here?

raveendrab’s picture

Hi,
Is there any hope that an updated working module be available?

kingfisher64’s picture

StatusFileSize
new12.28 KB

Download the #10 zip version then apply the patches from #19 or any other comments after #10 - that worked for me.

I don't have any errors popping up in the version i'm using - which i've attached. This include the global select all option from #15, so one check of a box can select all for a specified role.

The zip below includes all of the patches

himerus’s picture

Anyone interested in maintaining this module? I've had no time of late to pay attention to the queue, and would love to let someone take over that can get patches applied and hopefully revive development on the project...

defconjuan’s picture

Actually, yeah, I have time.

siteogra’s picture

#25 Thanks

loopduplicate’s picture

#25 works for me. Just download the whole zip file, no need to patch anything; patches are already applied. Thanks.
Actually, only the appearance changed. Clicking on the boxes didn't do anything. #25 did not work for me.
#10 is working great though :)

dflitner’s picture

StatusFileSize
new133.51 KB
new149.32 KB

#25 works for me but only if the Overlay is on. With the Overlay off, nothing happens when I click the global checkboxes at the top and the individual module checkboxes don't appear at all.

Screenshots attached.

jphelan’s picture

#25 worked for me.

agerson’s picture

subscribe

steveoliver’s picture

#32 agerson: FYI: There is now a big green Follow button at the top of each issue on drupal.org. Please use it instead of posting "subscribe" comments.

h3rj4n’s picture

StatusFileSize
new11.5 KB

#25 worked for me too.

But I don't find the layout very user friendly. Would one checkbox after the module name not be enough? It doesn't matter now which checkbox you click, you either select all, or select none (if all selected).

Would be awesome if it could work something like the checkbox in Gmail. It display's a - if you have something checked, and an empty checkbox if nothing is checked.

Also, it's slow! ;) Haven't looked at the code what can be improved but can't imagine it can't be faster.

kingfisher64’s picture

Is anyone interested in maintaining this mod? It's still a very very useful mod to use with the universal tick feature.

I wish I could maintain this project myself except i'm not up the standard of drupal core API knowledge to do so - at the moment.

Would be great to see if some coding guru could step up to just minimally maintain the project.

Posted in this rather that new issue queue as I thought more relevant people would see. :)

Any offers?

colan’s picture

Assigned: himerus » Unassigned
Priority: Normal » Critical
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new10.6 KB

Here's the above zip in proper patch format with Git metadata. I also fixed some obvious coding-standards violations.

Leeteq’s picture

Although only tested briefly, I can confirm that #25 seems to work nicely.
(Tested with Commons 3.2 (D7.21).)

How about releasing #25 along with the patch in #36 (I have not tested #36) as the new 7.x-1.x-dev version, so we can get some more testers?

colan’s picture

I'll happily put out a release if someone makes me a maintainer. :)

kingfisher64’s picture

@colan - himerus asked a while back for a new maintainer. Just ask him on http://drupal.org/user/159141 and I'm sure he'll make you the maintainer.

I'll gladly test the module or contribute in non php coding ways (not up to standard required with drupal yet). This is such a handy little module. There's a fair few small things that could be done to make it even more usable.

andyanderso’s picture

Thanks you guys for working on this module. It is a nice feature to have. I am unclear whether this has been rolled into the dev release yet or if I should go ahead and patch the stable release?

anybody’s picture

However, the current stable release does not work, so it can't be more bad! There should be a stable release based on the .dev version I think.

So let's have a short look, if the .dev version is already patched, else patch it and create a stable release from it? =)

It would be so great to see this running again!

colan’s picture

All: Please see #2064143: Offering to maintain Permission Select module. So after two (2) weeks, we should be able to get this rolling again.

badsit’s picture

Priority: Critical » Normal
Status: Needs review » Fixed

Updated release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.