In _simplemenu_add_css() the call to variable_set('simplemenu_css_filename', $output_filename) is somehow commented.

Consequence of this is the fact that _drupal_flush_css_js() is called on each page request, this produce a new query string attached to css and js files making impossible for browsers/proxies any kind of caching.

This is critical as it would result in a huge bandwidth overhead because at every request browsers will download whole css and js files again and again.

Attached patch fixes this.

Comments

AlexisWilke’s picture

Status: Needs review » Fixed

fax8,

Ah! Must be a left over from my debug sessions... Good catch.

It's checked in.

Thank you.
Alexis

fax8’s picture

Great, I would consider rolling out a new release because the consequences of this bug are pretty bad.

FV

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.