Closed (fixed)
Project:
SimpleMenu
Version:
6.x-1.9
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2010 at 16:08 UTC
Updated:
9 Sep 2010 at 06:40 UTC
In _simplemenu_add_css() the call to variable_set('simplemenu_css_filename', $output_filename) is somehow commented.
Consequence of this is the fact that _drupal_flush_css_js() is called on each page request, this produce a new query string attached to css and js files making impossible for browsers/proxies any kind of caching.
This is critical as it would result in a huge bandwidth overhead because at every request browsers will download whole css and js files again and again.
Attached patch fixes this.
| Comment | File | Size | Author |
|---|---|---|---|
| simplemenu_not_always_change_css_js_query_string.patch | 474 bytes | fax8 |
Comments
Comment #1
AlexisWilke commentedfax8,
Ah! Must be a left over from my debug sessions... Good catch.
It's checked in.
Thank you.
Alexis
Comment #2
fax8 commentedGreat, I would consider rolling out a new release because the consequences of this bug are pretty bad.
FV