The module file contains many large functions and themes that can be moved to another file. This will reduce the memory consumption for the average page load for most users, and it makes the module a little bit easier to comprehend.

All tests pass. I made no changes to any functions that moved to included files.

CommentFileSizeAuthor
#1 link-includes-887508-1.patch39.91 KBAnonymous (not verified)
link-includes.patch39.33 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
link-includes-887508-1.patch39.91 KB

Whoops. The tests pass only when you use the right patch!

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented

Sounds like a neat idea. Let me try it.

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented
Status: Needs review » Fixed

Okay, I've applied this to link-DRUPAL-6--2. It should show up as the 6.x-dev version soon.

Please give it a try, folks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

For users of Feeds module, the link mapper calls link_cleanup_url() without loading the include file. There's an issue for Feeds module with a patch. #891982: Support Link 2.x