Double discounting

I can confirm the double discounting issue.

Recrit--I believe you forgot to attach the patch you referred to =)

Hey recrit, thanks for the patch.
I am fully aware that this module is a big mess.
But i will rewrite the whole module from the ground up in the soon future.

Thanks for your contribution Recrit

I've tested this patch and it worked for me--no more double discounts.

The patch, however, failed to apply for me (I had to manually apply lines from chunks 2 and 4). Here is the .rej file I received

***************
*** 228,234 ****
  			$ptmaxd = uc_userpoints_discount_max();
  			$ptmaxdPoints = $ptmaxd * $multiplier;
  
- 			if (variable_get(USERPOINTS_DISCOUNT,1) != 0 && strtolower($order->payment_method) != 'points') {
  				if ((!empty($ptamt) || $ptamt != '') && $ptamt < $orderamt && $ptdisc <= min($curUserPoints, $ptmaxdPoints)) {
  					db_query("DELETE FROM {uc_order_line_items} WHERE order_id=%d AND type='ptdiscount'", $arg1->order_id);
  					db_query('INSERT INTO {uc_updiscounts} (uid, oid, ptamt, points) VALUES (%d, %d, \'%f\', %d)', $curUserId, $arg1->order_id, $ptamt, $points);
--- 217,223 ----
  			$ptmaxd = uc_userpoints_discount_max();
  			$ptmaxdPoints = $ptmaxd * $multiplier;
  
+ 			if (variable_get(USERPOINTS_DISCOUNT,1) != 0 && $paymethod != 'points') {
  				if ((!empty($ptamt) || $ptamt != '') && $ptamt < $orderamt && $ptdisc <= min($curUserPoints, $ptmaxdPoints)) {
  					db_query("DELETE FROM {uc_order_line_items} WHERE order_id=%d AND type='ptdiscount'", $arg1->order_id);
  					db_query('INSERT INTO {uc_updiscounts} (uid, oid, ptamt, points) VALUES (%d, %d, \'%f\', %d)', $curUserId, $arg1->order_id, $ptamt, $points);
***************
*** 289,295 ****
  			}
  			break;
  		case 'delete':
- 			if (variable_get(USERPOINTS_DISCOUNT,1) != 0 && strtolower($order->payment_method) != 'points') {
  				global $user;
  				$curUserId	= $user->uid;
  				$oid			= $order->order_id;
--- 278,284 ----
  			}
  			break;
  		case 'delete':
+ 			if (variable_get(USERPOINTS_DISCOUNT,1) != 0 && $paymethod != 'points') {
  				global $user;
  				$curUserId	= $user->uid;
  				$oid			= $order->order_id;

Hello betz,

I was wondering if there is a thread where we may follow the progress of the re-write of this module so the community can possibily help out with testing etc that is needed.

Looking forward to following your work!

yaz085,

To see the Issues for this module, go here:

http://drupal.org/project/issues/userpoints_ubercart

If you want to help with testing Ubercart Userpoints, go to the link below and download one of the versions that end with "-dev".

http://drupal.org/project/userpoints_ubercart

You may also notice that both of these links are in the breadcrumb at the top of the page :)

Just an FYI of what worked for me.

I manually inserted these 2 rejected chunks on my patch copy and the double discount error is fixed on my install.

Re-rolled the patch - no coding changes

I've never seen a patch in this format, I usually follow the instructions from http://drupal.org/patch/create

But your patch solves the / my problem. Thanks!

Patch worked for me too

thank you, worked ;)

I would like to get this issue resolved so that I can maybe clean up a few things or start on a D7 port depending upon what users would like but I cannot reproduce this using the latest dev release. Can someone confirm this is still happening and help me pinpoint where it is occurring?

I applied the patch and the problem is fixed.

In a side note... I applied the patch manually because it's in a format that I didn't know and the lines doesn't match... I applied it to the beta1 version

Hmm... I wish I knew why mine wasn't duplicating that behaviour. I will look at getting this patched and added in this weekend. Thanks for testing.

I still believe this not to be fixed.

See http://drupal.org/node/1056886

I still haven't found a way to reproduce this but I have applied the patch and commited it to the latest dev release.