I am getting the error message "Administrative menu items should have a description" from Coder Tough Love on a few lines that are MENU_CALLBACK and MENU_DEFAULT_LOCAL_TASK. I'm not necessarily against putting a description on them for code documentation purposes, but I don't think that description is ever displayed anywhere, so I think maybe a code comment would be a better way to document those menu items. If a #description is put there, it would need to be in t() and then translators would have extra work to do to translate text that is never displayed in the UI. Or am I wrong and those descriptions would be displayed somewhere? I don't think so...

So my opinion is that for MENU_CALLBACK and MENU_LOCAL_TASK and probably several other types of menu items, that warning should not be generated. Willing to be told I'm wrong, too. :)

CommentFileSizeAuthor
#2 menu_callback.patch1.82 KBaspilicious

Comments

tr’s picture

Version: 6.x-1.0 » 6.x-1.x-dev

I agree - the warning should not be generated for MENU_CALLBACK and MENU_LOCAL_TASK items.

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new1.82 KB

This is a D7 patch probably works for D6 to.

xjm’s picture

Status: Needs review » Reviewed & tested by the community

Tested and confirmed that #2 resolves the issue. Thanks @aspilicious!

xjm’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.