Share arguments won't work

I can second this bug....

the same here.
need to give both arguments, even if they are the same..
subscribe.

Got the same errors when setting shared arguments.
Be it with or without shared arguments the second argument is expected.

The whole where clause seems missing if either argument is not set.
The sql error points to the "WHERE ORDER BY " where theres no where clause added.

I get the same error.

I have
Views Or: Begin alternatives (share argument)
Nid
Views Or: Next alternative (share argument)
Nid
Views Or: Next alternative (share argument)
Nid
Views Or: Next alternative (share argument)
Nid
Views Or: End alternatives

When I enter argument 11 the SQL clause ends with only WHERE
When I enter 11/11/11/11 as argument the WHERE clause is written correctly in views UI preview.

When I remove the setting share argument in the next alternative setting, the same problem occurs.

I am seeing the same error.

Preliminarily, I'm having luck with a one-character edit on line 215 of views_or_handler_argument.inc, changing the != to a ==

I've not done much testing on this change, yet, and I don't have a full understanding of how the module operates to know for sure if this is an appropriate fix.

The fix in 6 works for me, thanks!

So, I guess that line 215 (as mentioned in post #6) is if ($this->view->args[$this->position] != '') {, quoted from

  function query() {
    $this->finish_alternative();
    $alt = &$this->query_current_alternative();
    if ($this->view->args[$this->position] != '') {
      if ($this->options['share_arguments']) {
        array_splice($this->view->args, $this->position, 0, array_slice($this->view->args, $alt['position'], $this->position - $alt['position']));
        $alt['position'] = $this->position;
      }
      else {
        array_splice($this->view->args, $this->position, 0, '');
      }
    }
  }

fix works for me as well.. any chance of getting this committed?

I tried the fix in #6 and it was not working for me. I get no query run when I enter a single argument or all 4 that I need

not sure if it helps.. but this is a screen of my View setup http://screencast.com/t/BbZSzOuFMu0B

and i only pass a single arg

yep, I can confirm this fixes the problem. Here's a patch in the hopes of getting it committed. If someone could try it and then RTBC this issue it might help move things along.

Confirmed the patch in #12 works.

Confirmed the patch in #12 works for me.

Confirmed the patch in #12 works for me.

Confirmed the patch in #12 works for me.

Confirmed patch in #12 works for me too.

Hm. With this patch view fails when "Share arguments" is set and there are two arguments. So, this solution is not correct... I.e. view can have more arguments not used in OR block....

As i think removing the whole condition is the best choice. Test on misc configs - works as expected - uses first arg for all alternatives when "share" is set no matter of args number. Please, test and confirm...

# diff -u views_or_handler_argument.inc.orig views_or_handler_argument.inc
--- views_or_handler_argument.inc.orig  2011-02-25 05:09:04.000000000 +0300
+++ views_or_handler_argument.inc       2011-05-07 17:04:21.000000000 +0400
@@ -211,14 +211,12 @@
   function query() {
     $this->finish_alternative();
     $alt = &$this->query_current_alternative();
-    if ($this->view->args[$this->position] != '') {
-      if ($this->options['share_arguments']) {
-        array_splice($this->view->args, $this->position, 0, array_slice($this->view->args, $alt['position'], $this->position - $alt['position']));
-        $alt['position'] = $this->position;
-      }
-      else {
-        array_splice($this->view->args, $this->position, 0, '');
-      }
+    if ($this->options['share_arguments']) {
+      array_splice($this->view->args, $this->position, 0, array_slice($this->view->args, $alt['position'], $this->position - $alt['position']));
+      $alt['position'] = $this->position;
+    }
+    else {
+      array_splice($this->view->args, $this->position, 0, '');
     }
   }
 }

I've tested both of these and they both work well. I am running into some issues when not passing any arguments at all but that can be restructured in the view. Can we get this in dev before it gets lost forever in issueland? You wouldn't believe the hacks I was doing before for similar functionality.

Here is a git re-roll of #19 for easy commit.

#20 works for me, please commit!

Fixed in commit c3294b8. Thanks to rump and Jim Kirkpatrick for reviewing skylord’s patch!

This patch broke functionality when arguments are not shared: #1340590: Default arguments not respected (and query broken?) when "Share arguments" is NOT indicated. It has been reversed until a safe patch is provided.